port cli to clap 4.0

[burrbull]

No description provided.

[fanninpm]

Similar in spirit to #3512

[fanninpm]

I believe you can use the following command to test your changes locally:

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features ssl,jit -- -m test -h.

[burrbull]

Looks like allow_hyphen_values on settings breaks parsing of command line.

[fanninpm]

That WASI failure seems to be unrelated.

[fanninpm]

If you aren't able to figure out why test_quopri.py is failing, asking @epage for help might be a good idea.

Related: clap-rs/clap#3903

[burrbull]

If you aren't able to figure out why test_quopri.py is failing, asking @epage for help might be a good idea.

Ok. How can I run only this one test?

[fanninpm]

Ok. How can I run only this one test?

I believe you can use the following command to test your changes locally:

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_quopri" (located at `Lib/test/test_quopri.py`)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_quopri

For a list of all resources and more command-line options, you can execute cargo run --release --features ssl,jit -- -m test -h.

[youknowone]

clap 4.1 is also out recently

[JamesClarke7283]

Any updates on this? is it going to be merged soon or shall i make a PR based on this one?

[burrbull]

Any updates on this? is it going to be merged soon or shall i make a PR based on this one?

Please, make a new one. I'll close this PR in favor of yours.