Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SAP/code-pal-for-abap
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: SAP/code-pal-for-abap
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.17.0
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 74 files changed
  • 8 contributors

Commits on Nov 1, 2021

  1. new version

    @lucasborin
    lucasborin committed Nov 1, 2021
    Copy the full SHA
    879b1c1 View commit details

Commits on Nov 2, 2021

  1. Quickfix: Pseudo Comment (#509) 

    * adding quickfixes

* Less than 3 newlines and at least a single newline are required in between metho

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>
    @lucasborin
    lucasborin and Lucas Borin authored Nov 2, 2021
    Copy the full SHA
    015dc72 View commit details

Commits on Nov 3, 2021

  1. Merge branch 'master' into 1.17.0

    @lucasborin
    lucasborin authored Nov 3, 2021
    Copy the full SHA
    14b18b8 View commit details

  2. fixing (#515) 

    Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>
    @lucasborin
    lucasborin and Lucas Borin authored Nov 3, 2021
    Copy the full SHA
    dd4ca0e View commit details

Commits on Nov 5, 2021

  1. Merge branch 'master' into 1.17.0

    @lucasborin
    lucasborin committed Nov 5, 2021
    Copy the full SHA
    fb664df View commit details

  2. abapgit 1.112.0

    Lucas Borin committed Nov 5, 2021
    Copy the full SHA
    9000edf View commit details

Commits on Nov 8, 2021

  1. remove unused variable (#522) 

    Co-authored-by: Eugen Günther <64586309+eugen-guenther-sap@users.noreply.github.com>
    @larshp
    larshp and Eugen Günther authored Nov 8, 2021
    Copy the full SHA
    87087d1 View commit details

Commits on Nov 11, 2021

  1. Merge branch 'master' into 1.17.0

    @lucasborin
    lucasborin committed Nov 11, 2021
    Copy the full SHA
    34279e1 View commit details

Commits on Nov 17, 2021

  1. mass change of check data (#507) 

    * 1.16.0

* enabling changelog

* RAP needs CREATE OBJECT ... FOR TESTING (#448)

* resolves #444

* changelog

* COLLECT restrictions (#442)

* new check

* abapLint

* supporting programs

* closing gaps

* adding documentation

* Adding Changelog

* exempt ddic typed table

* supporting ddic table type

* supporting header line

* removing gap section

* supporting class attributes

* Use functional writing style for method calls

* Adding example

* Prefer Pragmas to Pseudo Comments (#446)

* new check

* new check

* documentation

* exempting SLIN

* Adding example

* Unit-Test Assert Validator (#450)

* Unit-Test Assert Validator 

resolve #449

* changelog

* BAdI example class vs Percentage Comment (#451)

* BAdI example class vs Percentage Comment

resolve #443

* changelog

* Allow Exemptions (#453)

* big refactoring

* isolating unit tests

* changelog

* forcing commit

* forcing commit

* Handle functional operand in assert check (#462)

* Functional operand check

* Fix unit test and nesting syntax

* Lint

* Update exemption unit test

* Fix unit test

* Add functional operand fix #460 to changelog

* removing static test, and adding more test cases

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.com>

* Unit Test on 752 (#463)

* fix #461

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Refactoring Code Pal (#457)

* saving progress

* saving progress

* Update changelog.txt

* global class vs local class

* local vs global test class

* Global Test Class fix

* enabling unit test

* refactoring y_check_function uts

* abaplint feedback

* abaplint feedback

* removing unecessary fields and fixing checksum

* fixing coverages (statement)

* default noaunit for test

* fixing bug in chain declaration

* fixing unit test

* Less than 3 newlines and at least a single newline are required in between metho

* ref #461

* solving conflict

* Update changelog.txt

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fixing collect dump

* fixing pseudo comment dump and performance issue

* reusing refscan (performance)

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* pseudo comment refactoring (performance)

* collect (performance)

* Update changelog.txt

* Reorder definitions to top of routine

* pseudo_comment_usage ignore_pseudo

* more performance improvements

* removing deprecated methods

* activating prefer_inline (#465)

* activating prefer_inline

* Prefer Inline Declarations, PERCENTAGE

* Prefer Inline Declarations, RISK_LVL

* Prefer Inline Declarations, HAS_REDIRECTION

* Prefer Inline Declarations, TITLE

* Prefer Inline Declarations, CLASS_SEARCH_STRING

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* performance improvement (check statement pos)

* Prefer Inline Declarations, PROFILE_CONFIGURATIONS

* Line break multiple parameters

* Reorder definitions to top of routine

* Update changelog.txt

* magic number

* adding pseudo comments

* Adding pseudo comment

* Fixing magic number

* Use | to assemble text!

* Use | to assemble text!

* Prefer RETURNING to EXPORTING!

* Prefer LINE_EXISTS or LINE_INDEX to READ TABLE or LOOP AT!

* Prefer IS NOT to NOT IS!

* replacing pseudo

* removing unecessary pseudos

* unecessary pseudo

* clean coding f4call

* new SAP note dependency

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* use native *_wa variables (#475)

* resolves #474

* changelog

* forcing commit

* restore

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* disabling abaplint check_syntax

* Magic Number: Table Index  (#477)

* resolves #474

* fix #475

* fixing case

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Prefer New to Create Object: Dynamic Type (#478)

* Fixes #469

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Magic Number: Leading Zeros (#479)

* fixing magic number for leading zeros

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Magic Number: CASE SY-TABIX and CO NUMBERS (#480)

* case sy-tabix and Co numbers

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Y_CHECK_FORM: Screen Events (#482)

* Fixes #454

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Empty Catch: Test Double Framework (#483)

* Fixes #332

* Missing space between string or character literal and parentheses

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* line_exists does not support the operator IN (#485)

* Fixes #484

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Alternative Pseudo Comment (#486)

* saving progress

* saving progress

* saving progress

* alternative pseudo

* fixing 7.40 compatibility

* 7.40 compatibility

* revert checksum

* adjusting pseudo comment usage

* adding unit tests

* Missing space between string or character literal and parentheses

* new pseudo comment

* changelog

* alt_pcom in ut

* Update empty_catch.md

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Chain Declaration for Complex Structures (#488)

* new test scope

* fixes #466

* cleaning self-reference

* cleaning chain declaration

* cleaning chain declaration

* cleaning chain declaration

* fixing syntax error

* changelog

* documentation

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* fixing syntax error

* `Y_CHECK_MESSAGE_EASY_TO_FIND` dump (#492)

* fixes #491

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* short review (#493)

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Prefer Pragmas to Pseudo Comments (#495)

* fixes #489

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Pseudo Comment Usage: Multiple Inline Entries (#496)

* fixes #494

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* Skip `Prefer RETURNING to EXPORTING` when both exist (#497)

* fixes #490

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* DB Access in UT: Local Inheritance (#498)

* partially solves #433

* changelog

* renaming variable

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* DB Access in UT: Global Inheritance (#500)

* fixes #433

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* fixing short dump (#501)

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* removing unecessary pseudo comment

* Prefer New: Dynamic Call with Parameters (#503)

* fixes #502

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>

* mass change of check data

* Update changelog.txt

* UI finetuning

* minor change

* abaplint compliance

* abaplint picky compliance

* UI Changes

* Revert "UI Changes"

This reverts commit cac373d.

* UI Changes

* small UI adjustments

* Update changelog.txt

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.com>
Co-authored-by: Mike Pokraka <mike@quirky.me.uk>
Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
    @lucasborin @pokrakam @abaplint
    5 people authored Nov 17, 2021
    Copy the full SHA
    828f2ae View commit details

  2. Refactoring Quick Fixes (#523) 

    * quickfixes are now mandatory

* first check + message

* no quickfix

* wip

* implementing abstract method

* pseudo comments won't enable the quickfix

* removing unnecessary :

* removing duplicated quick fix

* changelog

Co-authored-by: Lucas Borin <5233413+lucasborin@users.noreply.github.co>
Co-authored-by: Eugen Günther <64586309+eugen-guenther-sap@users.noreply.github.com>
    @lucasborin
    3 people authored Nov 17, 2021
    Copy the full SHA
    4e063f8 View commit details

Commits on Jan 26, 2022

  1. Replace class by interface in check documentation (#543) 

    * Update test-seam-usage.md

* Update db-access-in-ut.md

* Update external-call-in-ut.md

* Update unit_test_assert.md

* Replace class by interface

In the check "Constants Interface Check", the documentation of the exception referred to class definition instead of interface definition.

* Update db-access-in-ut.md

* Update external-call-in-ut.md

* Update test-seam-usage.md

* Update test-seam-usage.md

* Update unit_test_assert.md

* Update unit_test_assert.md

* Update unit_test_assert.md

Co-authored-by: estevao-schultz-neto-SAP <63100656+estevao-schultz-neto-SAP@users.noreply.github.com>
Co-authored-by: Eugen Günther <64586309+eugen-guenther-sap@users.noreply.github.com>
    @schneidermic0 @estevao-schultz-neto-SAP
    3 people authored Jan 26, 2022
    Copy the full SHA
    947a862 View commit details

  2. Update changelog.txt

    Eugen Günther authored Jan 26, 2022
    Copy the full SHA
    51d7d76 View commit details

  3. Update changelog.txt

    Eugen Günther authored Jan 26, 2022
    Copy the full SHA
    1a3e206 View commit details

Commits on Feb 8, 2022

  1. Merge branch 'master' into 1.17.0

    Eugen Günther authored Feb 8, 2022
    Copy the full SHA
    3263c0c View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff master...1.17.0