Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][bidi]: use getBidiSessionStatus method in tests #15403

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

navin772
Copy link
Member

@navin772 navin772 commented Mar 12, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Motivation and Context

Used getBidiSessionStatus method in tests instead of sending a raw Command again

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Tests


Description

  • Replaced raw Command usage with getBidiSessionStatus in tests.

  • Simplified BiDi session status retrieval for better readability.

  • Updated multiple test cases to use the new method.


Changes walkthrough 📝

Relevant files
Tests
BiDiSessionCleanUpTest.java
Refactored BiDi session status retrieval in cleanup tests

java/test/org/openqa/selenium/bidi/BiDiSessionCleanUpTest.java

  • Replaced send method with getBidiSessionStatus for BiDi session
    status.
  • Simplified exception handling for BiDi session closure.
  • Improved readability of BiDi session-related test cases.
  • +4/-11   
    BiDiSessionTest.java
    Updated BiDi session creation test                                             

    java/test/org/openqa/selenium/bidi/BiDiSessionTest.java

  • Replaced send method with getBidiSessionStatus.
  • Simplified BiDi session creation test logic.
  • +1/-2     
    RemoteWebDriverBiDiTest.java
    Refactored BiDi session creation verification test             

    java/test/org/openqa/selenium/grid/router/RemoteWebDriverBiDiTest.java

  • Replaced send method with getBidiSessionStatus.
  • Simplified BiDi session creation verification.
  • +1/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Mar 12, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @navin772
    Copy link
    Member Author

    @navin772 navin772 requested a review from VietND96 March 17, 2025 06:02
    @VietND96 VietND96 merged commit e60ce06 into SeleniumHQ:trunk Mar 19, 2025
    11 checks passed
    @navin772 navin772 deleted the java-session-status-test-fix branch March 20, 2025 03:03
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants