-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] [bidi] Make LogEntry
as not nested
#15432
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small future-proofing change
User description
Motivation and Context
Contributes to #15407
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Refactored nested DTO types to standalone classes for better extensibility.
Updated
LogEntry
and related types to standalone classes.Adjusted JSON serialization and deserialization logic for new class structure.
Updated tests to align with refactored
LogEntry
structure.Changes walkthrough 📝
5 files
Updated JSON serialization for refactored `LogEntry` types
Adjusted polymorphic converter for `LogEntry` refactor
Updated method signatures to use new `LogEntry` types
Refactored `Entry` and nested types to standalone `LogEntry` classes
Updated `LogModule` to use refactored `LogEntry` types
2 files
Updated tests to align with `LogEntry` refactor
Adjusted script command tests for `LogEntry` changes