Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged Changes #6190

Merged
merged 28 commits into from
Mar 12, 2025
Merged

Merged Changes #6190

merged 28 commits into from
Mar 12, 2025

Conversation

sadiul-hakim
Copy link
Contributor

@sadiul-hakim sadiul-hakim commented Mar 10, 2025

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 35.15152% with 107 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (9bfc05a) to head (f6b3c40).

Files with missing lines Patch % Lines
...main/java/com/thealgorithms/maths/MathBuilder.java 26.89% 96 Missing and 10 partials ⚠️
...healgorithms/others/PrintAMatrixInSpiralOrder.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6190      +/-   ##
============================================
- Coverage     74.16%   73.80%   -0.36%     
- Complexity     5208     5220      +12     
============================================
  Files           665      667       +2     
  Lines         17818    17983     +165     
  Branches       3429     3457      +28     
============================================
+ Hits          13214    13272      +58     
- Misses         4099     4195      +96     
- Partials        505      516      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sadiul-hakim
Copy link
Contributor Author

{1FB1E1B7-B06D-42B3-A414-014A0E5DDD30}
I do not know how to fix this one. No matter whatever i do it keeps complaining.

@sadiul-hakim
Copy link
Contributor Author

{2FE2B5E2-40E6-4FA7-B971-93BE0A877760}
Now what? 🥲

@siriak
Copy link
Member

siriak commented Mar 11, 2025

@sadiul-hakim the linter tells you to replace tabs with spaces
image

@sadiul-hakim
Copy link
Contributor Author

Is CheckStyle and Clang format automatic on your end? I had a hard time. I use intelij how can i make this automatic?

@siriak
Copy link
Member

siriak commented Mar 12, 2025

No, it's manual. I usually check in logs of failed PR check to see what failed. You can add them with a Git hook to run them before commit, but it should be done by everyone separately

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit e6073f8 into TheAlgorithms:master Mar 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants