-
Notifications
You must be signed in to change notification settings - Fork 43
[WEB-4460] fix: preserve lang param in content links #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
7f31677
to
2a1db61
Compare
2a1db61
to
deeea70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly for MDX, but we also seem to have introduced a regression to textile whenever we broke this. Happy to approve this and deal with textile separately, or include it in here - whichever is easiest.
@m-hulbert I'll take a look and let you know if it's a disproportionately large faff |
deeea70
to
d45e439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Raised by @m-hulbert.
Links in content in MDX pages need to preserve any active lang params so that we get a consistent language experience between pages.
Review: https://ably-docs-web-4440-pres-2duhlf.herokuapp.com/docs/chat/rooms?lang=react