Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table in selection mode should not prevent Row actions #7962

Open
selrond opened this issue Mar 19, 2025 · 4 comments
Open

Table in selection mode should not prevent Row actions #7962

selrond opened this issue Mar 19, 2025 · 4 comments

Comments

@selrond
Copy link

selrond commented Mar 19, 2025

Provide your feedback here.

From the docs:

When at least one item is selected, the table is in selection mode, and clicking or tapping a row toggles the selection.

I believe this is too restrictive. Is there a reason a row action is inaccessible when this selection "mode" is in play?

Selection could still be controlled through other means (checkboxes for instance), while allowing the row actions.

Version

1.7.0

@LFDanLu
Copy link
Member

LFDanLu commented Mar 19, 2025

If I remember correctly, this behavior was mainly for mobile users. There were cases design wise where checkboxes are omitted by default from the Table and mobile users would enter the "toggle" selection mode via pressing and holding on a target row. Since the last action was to select a row, we figured that intuitively next taps on subsequent rows would for further selection rather than performing an action on a different row.

What kind of user flow are you envisioning here where you'd like the row action to fire on subsequent pressed after toggling selection for a row?

@selrond
Copy link
Author

selrond commented Mar 24, 2025

What kind of user flow are you envisioning here where you'd like the row action to fire on subsequent pressed after toggling selection for a row?

Nothing fancy or unusual, really.
Row actions are extremely common, and usually have some affordance for toggling selection (checkboxes) designed.
If a user selects a row (using the checkbox), it’s quite unexpected to have the row action blocked / seemingly replaced by this selection mode behavior change.

For instance, if the main row action is opening a sidebar with more row details, and a user is selecting some rows in preparation for a bulk action of some kind, and want to quickly check some row details to guide their decision, it’s not possible currently. They’d have to either clear the entire selection to be able to trigger the row action, or change the design and introduce some kind of button to do so.

@selrond
Copy link
Author

selrond commented Mar 27, 2025

@LFDanLu does this make sense? I haven’t studied the source for this, but if you / the team is good with it, I could try to implement some flag

@LFDanLu
Copy link
Member

LFDanLu commented Mar 27, 2025

Yeah, I agree that it there is merit to preserve the interaction required to trigger the row action rather than flip it when a row becomes selected. Will have to bring this up to the team to see if others have any opinions or have findings from user testing from when this was first implemented, I'm having trouble digging up any notes from that time myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants