Skip to content

Commit 5d1702e

Browse files
authored
Enumerator should use a non-blocking fiber, change rb_fiber_new to be non-blocking by default. (ruby#10481)
1 parent cccffef commit 5d1702e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

cont.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2382,7 +2382,7 @@ rb_fiber_initialize(int argc, VALUE* argv, VALUE self)
23822382
VALUE
23832383
rb_fiber_new_storage(rb_block_call_func_t func, VALUE obj, VALUE storage)
23842384
{
2385-
return fiber_initialize(fiber_alloc(rb_cFiber), rb_proc_new(func, obj), rb_fiber_pool_default(Qnil), 1, storage);
2385+
return fiber_initialize(fiber_alloc(rb_cFiber), rb_proc_new(func, obj), rb_fiber_pool_default(Qnil), 0, storage);
23862386
}
23872387

23882388
VALUE

test/fiber/test_enumerator.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,12 @@ def test_read_characters
4242
assert_predicate(i, :closed?)
4343
assert_predicate(o, :closed?)
4444
end
45+
46+
def enumerator_fiber_is_nonblocking
47+
enumerator = Enumerator.new do |yielder|
48+
yielder << Fiber.current.blocking?
49+
end
50+
51+
assert_equal(false, enumerator.next)
52+
end
4553
end

0 commit comments

Comments
 (0)