build: update integration tests to use first-party packages

Updates integration tests to work with the linked first-party packages.

Author: devversion

integration/BUILD.bazel

@@ -1,10 +1,5 @@
-load("@build_bazel_rules_nodejs//:index.bzl", "js_library")
+load("@npm2//:defs.bzl", "npm_link_all_packages")
 
 package(default_visibility = ["//visibility:public"])
 
-# JavaScript library that exposes a script for retrieving all NPM packages
-# available in the runfiles of an action.
-js_library(
-    name = "npm-packages-from-runfiles",
-    srcs = ["npm-packages-from-runfiles.mjs"],
-)
+npm_link_all_packages()

integration/linker/BUILD.bazel

@@ -10,7 +10,6 @@ js_test(
         "//:node_modules/@babel/core",
         "//:node_modules/chalk",
         "//:node_modules/glob",
-        "//integration:npm-packages-from-runfiles",
         "//src/cdk:npm_package",
         "//src/cdk-experimental:npm_package",
         "//src/google-maps:npm_package",

integration/npm-packages-from-runfiles.mjs

@@ -1 +1,10 @@
-{}
+{
+  "dependencies": {
+    "@angular/cdk": "workspace:*",
+    "@angular/cdk-experimental": "workspace:*",
+    "@angular/material": "workspace:*",
+    "@angular/material-experimental": "workspace:*",
+    "@angular/google-maps": "workspace:*",
+    "@angular/youtube-player": "workspace:*"
+  }
+}

integration/package.json

@@ -1,5 +1,5 @@
 load("@bazel_skylib//rules:write_file.bzl", "write_file")
-load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_test")
+load("@aspect_rules_js//js:defs.bzl", "js_test")
 load("//integration/ts-compat:import-all-entry-points.bzl", "generate_import_all_entry_points_file")
 
 package(default_visibility = ["//visibility:public"])
@@ -18,24 +18,23 @@ typescript_version_packages = [
 
 # Generates a NodeJS test for each configured TypeScript version.
 [
-    nodejs_test(
+    js_test(
         name = ts_pkg_name,
         args = [ts_pkg_name],
+        chdir = package_name(),
         data = [
             "helpers.mjs",
             "test.mjs",
             ":import-all-entry-points-file",
-            "//integration:npm-packages-from-runfiles",
-            "//src/cdk:npm_package",
-            "//src/cdk-experimental:npm_package",
-            "//src/google-maps:npm_package",
-            "//src/material:npm_package",
-            "//src/material-experimental:npm_package",
-            "//src/youtube-player:npm_package",
-            "@npm//@bazel/runfiles",
-            "@npm//shelljs",
-            "@npm//%s" % ts_pkg_name,
-            "@npm//@types/node",
+            "//:node_modules/shelljs",
+            "//integration:node_modules/@angular/cdk",
+            "//integration:node_modules/@angular/cdk-experimental",
+            "//integration:node_modules/@angular/google-maps",
+            "//integration:node_modules/@angular/material",
+            "//integration:node_modules/@angular/material-experimental",
+            "//integration:node_modules/@angular/youtube-player",
+            "//:node_modules/%s" % ts_pkg_name,
+            "//:node_modules/@types/node",
         ],
         entry_point = "test.mjs",
     )

integration/ts-compat/BUILD.bazel

@@ -1,21 +1,12 @@
-import {join} from 'path';
-import {unlinkSync} from 'fs';
+import path from 'path';
 import shelljs from 'shelljs';
 import {fork} from 'child_process';
-import {getNpmPackagesFromRunfiles} from '../npm-packages-from-runfiles.mjs';
-import {runfiles} from '@bazel/runfiles';
 
 // Exit if any command fails.
 shelljs.set('-e');
 
-// List of NPM packages that have been built for the current test target.
-const npmPackages = getNpmPackagesFromRunfiles();
-// Path to the node modules of the workspace.
-const nodeModulesDir = runfiles.resolve('npm/node_modules');
 // Path to the generated file that imports all entry-points.
-const testFilePath = runfiles.resolveWorkspaceRelative(
-  'integration/ts-compat/import-all-entry-points.ts',
-);
+const testFilePath = path.resolve('./import-all-entry-points.ts');
 
 /**
  * Runs the TypeScript compatibility test with the specified tsc binary. The
@@ -24,42 +15,20 @@ const testFilePath = runfiles.resolveWorkspaceRelative(
  */
 export async function runTypeScriptCompatibilityTest(tscBinPath) {
   return new Promise((resolve, reject) => {
-    const angularDir = join(nodeModulesDir, '@angular/');
-
-    // Create the `node_modules/@angular` directory in case it's not present.
-    shelljs.mkdir('-p', angularDir);
-
-    // Symlink npm packages into `node_modules/` so that the project can
-    // be compiled without path mappings (simulating a real project).
-    for (const {name, pkgPath} of npmPackages) {
-      console.info(`Linking "@angular/${name}" into node modules..`);
-      shelljs.ln('-sf', pkgPath, join(angularDir, name));
-    }
-
     const tscArgs = [
       '--strict',
       // Disables automatic type resolution. In non-sandbox environments, the node modules
       // are accessible and types could end up as part of the program.
       '--types',
       '--lib',
       'es2015,dom',
-      // Ensures that `node_modules` can be resolved. By default, in sandbox environments the
-      // node modules cannot be resolved because they are wrapped in the `npm/node_modules` folder
-      '--baseUrl',
-      nodeModulesDir,
       testFilePath,
     ];
     // Run `tsc` to compile the project. The stdout/stderr output is inherited, so that
     // warnings and errors are printed to the console.
     const tscProcess = fork(tscBinPath, tscArgs, {stdio: 'inherit'});
 
     tscProcess.on('exit', exitCode => {
-      // Remove symlinks to keep a clean repository state.
-      for (const {name} of npmPackages) {
-        console.info(`Removing link for "@angular/${name}"..`);
-        unlinkSync(join(angularDir, name));
-        shelljs.rm('-rf', join(angularDir, name));
-      }
       exitCode === 0 ? resolve() : reject();
     });
   });

integration/ts-compat/helpers.mjs

@@ -4,16 +4,16 @@
  * by a Bazel `nodejs_test` target and relies on Bazel runfile resolution.
  */
 
-import {runfiles} from '@bazel/runfiles';
 import {runTypeScriptCompatibilityTest} from './helpers.mjs';
+import path from 'path';
 
 const [pkgName] = process.argv.slice(2);
 if (!pkgName) {
   console.error('No TypeScript package specified. Exiting..');
   process.exit(1);
 }
 
-const tscBin = runfiles.resolve(`npm/node_modules/${pkgName}/bin/tsc`);
+const tscBin = path.resolve(`../../node_modules/${pkgName}/bin/tsc`);
 
 runTypeScriptCompatibilityTest(tscBin).catch(e => {
   console.error(e);