Initial PR for migrating to `rules_js` #30629

devversion · 2025-03-14T07:39:49Z

See individual commits

crisbeto

Do we also plan to update the various utility scripts (e.g. yarn test) and the docs?

josephperrott

LGTM

josephperrott · 2025-03-17T16:55:58Z

WORKSPACE

 load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")

+NODE_VERSION = "22.0.0"


Shouldn't we be on 20.11.1?

Typically we have our version of node within our repository as the earliest maintenance version (and moving to 20 now instead of waiting til mid april makes sense to me) instead of the current version.

I know that it was already at 22.0.0 when you moved this part over, but I wanted to check in on this now.

I think for the Bazel invocation it doesn't necessarily matter as everyone gets the same. What do you think would be the value for staying at the earliest maintenance version?

Since we still support the lower versions, the value is mostly in making sure we don't incidentally rely on something unsupported in the lower versions. It likely doesn't really make a difference, but just wanted to flag it

Yeah, I think for CLI this matters, but here the risk is very low yeah.

Good idea to follow-up on this though. I can see this being a potential issue for the shipped schematics code.

josephperrott · 2025-03-17T16:58:09Z

WORKSPACE

+rules_ts_dependencies(
+    # Obtained by: curl --silent https://registry.npmjs.org/typescript/5.8.2 | jq -r '.dist.integrity'
+    ts_integrity = "sha512-aJn6wq13/afZp/jT9QZmwEjDqqvSGp1VT5GVg+f/t6/oVyrgXM6BY1h9BRh/O5p3PlUPAe+WuiEZOmb/49RqoQ==",
+    ts_version_from = "//:package.json",


Note that I don't know if we want to align on, for angular-cli we define the ts_version here instead of getting it from package.json. I don't have a really strong feeling on either way, but since we have to obtain the integrity sha anyway, maybe it makes sense to have the version directly defined here as well.

Yeah, in CLI I have a clean-up PR (blocked currently) that also leverages the version from the package.json

I see your point. Not feeling strongly, but ideally, long-term rules_js would automatically have the right integrity available. That's what I'm hoping for.

josephperrott · 2025-03-17T16:59:17Z

WORKSPACE

+    remote = "https://github.com/angular/dev-infra.git",
+)
+
+load("@devinfra//bazel:setup_dependencies_1.bzl", "setup_dependencies_1")


Noting this while I am looking at it now. We should name these setup functions to include the repo they are setting up so that we don't have name collisions in the functions we bring in as well.

Agreed. Let's follow-up on this and also align rules_angular

josephperrott · 2025-03-17T17:00:27Z

goldens/cdk/collections/index.api.md

@@ -1,4 +1,4 @@
-## API Report File for "components-srcs"
+## API Report File for "@angular/cdk_collections"


Nit: In an ideal world we would have the package string listing here correctly end up with the deeper entry point @angular/cdk/collections

Agreed, that's a fix we'd need to make in api_golden

josephperrott

LGTM

Can we also include the necessary updates to renovate.json for the pnpm-lockfile changes?

devversion · 2025-03-17T17:31:48Z

Do we also plan to update the various utility scripts (e.g. yarn test) and the docs?

@crisbeto for sure! Can you help quickly in how you think yarn test is affected? I thought it should be unaffected by this PR at least for now

crisbeto · 2025-03-17T17:49:50Z

yarn test should work if the test targets follow the same pattern as before. That being said, we have a bunch of docs that are referring to Yarn instead of pnpm.

devversion · 2025-03-17T17:53:20Z

yeah, they follow the same convention, so should work.

Also this is just the initial PR and we are doing an incremental migration. You will still use yarn but occasionally need to run bazel run @npm2//:sync to update the lock file, when updating dependencies.

Will make this more clear in the team's Slack chat.

This is necessary for an incremental migration to `rules_js` which requires Bazel v6. Bazel v6 removed the managed directories feature, which means we no longer can rely on symlinked node modules as the Bazel repository; but rather need to duplicate dependencies. This is okay/acceptable to enable the incremental migration.

Sets up `rules_js` and links dependencies into the bazel-bin.

This commit sets up `rules_ts`, providing the `ts_library` equivalent for the `rules_js` migration.

The `ts_project` interop rule that we've built was also used in the Angular CLI migration, and it allows us to mix `ts_project` and `ts_library` targets; enabling an incremental migration.

This is an initial commit to migrate some `testing/` targets to `ts_project`, leveraging the interop rule we've built. Notably we also turn of strict deps checking temporarily as the deps checking is only applicable when there are no interop deps anymore!

* Moves the public API goldens to `goldens/` * Switches us to the `npm_package` variant of the golden testing rule. This variant is more future proof and will work well with the `rules_js` migration (as it takes arbitrary Bazel tree artifacts)

This will automatically result in Renovate updating the Aspect lock files.

This will result in the release tool automatically updating the Aspect lock files when necessary.

angular-robot bot added the area: build & ci label Mar 14, 2025

devversion force-pushed the initial-rjs branch 5 times, most recently from f452498 to f3b322b Compare March 17, 2025 16:15

devversion requested a review from crisbeto March 17, 2025 16:23

devversion added target: patch action: review labels Mar 17, 2025

devversion marked this pull request as ready for review March 17, 2025 16:23

devversion requested review from a team, andrewseguin and jelbourn as code owners March 17, 2025 16:23

crisbeto approved these changes Mar 17, 2025

View reviewed changes

josephperrott approved these changes Mar 17, 2025

View reviewed changes

devversion added 6 commits March 18, 2025 12:32

build: setup rules_js and link dependencies

80e7715

Sets up `rules_js` and links dependencies into the bazel-bin.

build: setup rules_ts for compiling TypeScript sources

18ffb09

This commit sets up `rules_ts`, providing the `ts_library` equivalent for the `rules_js` migration.

build: set up ts_project interop for rules_js migration

d686d81

The `ts_project` interop rule that we've built was also used in the Angular CLI migration, and it allows us to mix `ts_project` and `ts_library` targets; enabling an incremental migration.

devversion force-pushed the initial-rjs branch from f3b322b to 0fd84f3 Compare March 18, 2025 12:32

devversion added 2 commits March 18, 2025 12:44

build: update renovate config for rules_js hybrid mode

94a1982

This will automatically result in Renovate updating the Aspect lock files.

build: enable rules_js interop mode in ng-dev release

a5899a7

This will result in the release tool automatically updating the Aspect lock files when necessary.

devversion removed the request for review from jelbourn March 18, 2025 13:00

devversion removed the request for review from andrewseguin March 18, 2025 13:00

devversion added merge: preserve commits action: merge target: minor and removed action: review target: patch labels Mar 18, 2025

devversion merged commit 23269f3 into angular:main Mar 18, 2025
23 of 26 checks passed

devversion mentioned this pull request Mar 19, 2025

Patch port of initial rules_js migration PR #30654

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial PR for migrating to `rules_js` #30629

Initial PR for migrating to `rules_js` #30629

devversion commented Mar 14, 2025

crisbeto left a comment

josephperrott left a comment

josephperrott Mar 17, 2025

devversion Mar 17, 2025

josephperrott Mar 17, 2025

devversion Mar 17, 2025

josephperrott Mar 17, 2025

devversion Mar 17, 2025

devversion Mar 17, 2025

josephperrott Mar 17, 2025

devversion Mar 17, 2025

josephperrott Mar 17, 2025

devversion Mar 17, 2025

josephperrott left a comment

devversion commented Mar 17, 2025

crisbeto commented Mar 17, 2025

devversion commented Mar 17, 2025 •

edited

Loading

		load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")

		NODE_VERSION = "22.0.0"

		@@ -1,4 +1,4 @@
		## API Report File for "components-srcs"
		## API Report File for "@angular/cdk_collections"

Initial PR for migrating to rules_js #30629

Initial PR for migrating to rules_js #30629

Conversation

devversion commented Mar 14, 2025

crisbeto left a comment

Choose a reason for hiding this comment

josephperrott left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josephperrott left a comment

Choose a reason for hiding this comment

devversion commented Mar 17, 2025

crisbeto commented Mar 17, 2025

devversion commented Mar 17, 2025 • edited Loading

Initial PR for migrating to `rules_js` #30629

Initial PR for migrating to `rules_js` #30629

devversion commented Mar 17, 2025 •

edited

Loading