Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/autocomplete): allow overlay backdrop by setting hasBackdrop option #30631

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix(material/autocomplete): allow overlay backdrop by setting hasBackdrop option #30631

merged 1 commit into from
Mar 18, 2025

Conversation

mistrykaran91
Copy link
Contributor

@mistrykaran91 mistrykaran91 commented Mar 14, 2025 •
edited
Loading

Currently when we open the panel, backdrop is not allowed and is not inline with mat-select, mat-menu, etc. This fix will align autocomplete with those components and give an option to configure it.

Fixes #30457

@mistrykaran91 mistrykaran91 requested a review from a team as a code owner March 14, 2025 13:08
@mistrykaran91 mistrykaran91 requested review from crisbeto and andrewseguin and removed request for a team March 14, 2025 13:08
@mistrykaran91 mistrykaran91 force-pushed the fix/automcomplete-overlay-backdrop branch 3 times, most recently from d89d3ce to f1b5dc5 Compare March 15, 2025 11:30
@crisbeto crisbeto removed the request for review from andrewseguin March 18, 2025 10:20
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Mar 18, 2025
@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Mar 18, 2025
@mistrykaran91 mistrykaran91 force-pushed the fix/automcomplete-overlay-backdrop branch from 31db0f1 to 2cea4f0 Compare March 18, 2025 11:06
@mistrykaran91 mistrykaran91 requested a review from crisbeto March 18, 2025 11:18
@mistrykaran91 mistrykaran91 changed the title fix(material/autocomplete): allow overlay backdrop when opened fix(material/autocomplete): allow overlay backdrop by setting hasBackdrop option Mar 18, 2025
@mistrykaran91
Copy link
Contributor Author

mistrykaran91 commented Mar 18, 2025 •
edited
Loading

@crisbeto : Seems action:merge label was removed and not added after the later approval or it will be added later ?

@crisbeto
Copy link
Member

I'll add it before merging the change in.

@angular-robot angular-robot bot requested a review from crisbeto March 18, 2025 13:10
@mistrykaran91
fix(material/autocomplete): allow overlay backdrop by setting hasBack…
284976e 
…drop option

Currently when we open the panel, backdrop is not allowed and is not inline with `mat-select`, `mat-menu`, etc. This fix will align autocomplete with those components and give an option to configure it.

Fixes angular#30457
@mistrykaran91 mistrykaran91 force-pushed the fix/automcomplete-overlay-backdrop branch from 8b6b28e to 284976e Compare March 18, 2025 13:11
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 18, 2025
@crisbeto crisbeto merged commit 097f49d into angular:main Mar 18, 2025
20 of 22 checks passed
@ThisUsernameIsAllreadyTaken
Copy link

I didn't verify this, but I am currently experiencing issues as described in #26484 and seem to be resolved when the backdrop is added.

I believe this would also fix #26484 and #30416?

As I've seen this is not added to a 19.x.x but to https://github.com/angular/components/releases/tag/20.0.0-next.2

Would it be possible to pick this also into a 19.x.x release?

@ThisUsernameIsAllreadyTaken
Copy link

I didn't verify this, but I am currently experiencing issues as described in #26484 and seem to be resolved when the backdrop is added.

I believe this would also fix #26484 and #30416?

As I've seen this is not added to a 19.x.x but to https://github.com/angular/components/releases/tag/20.0.0-next.2

Would it be possible to pick this also into a 19.x.x release?

@crisbeto maybe you can help me with that?

crisbeto pushed a commit to crisbeto/material2 that referenced this pull request Mar 26, 2025
@mistrykaran91 @crisbeto
fix(material/autocomplete): allow overlay backdrop by setting hasBack…
e23bbdf 
…drop option (angular#30631)

Currently when we open the panel, backdrop is not allowed and is not inline with `mat-select`, `mat-menu`, etc. This fix will align autocomplete with those components and give an option to configure it.

Fixes angular#30457
@crisbeto crisbeto mentioned this pull request Mar 26, 2025
Merged
@crisbeto
Copy link
Member

Will be cherry-picked by #30715.

crisbeto added a commit that referenced this pull request Mar 26, 2025
@crisbeto @DavidACCarvalho @mistrykaran91
Cherry pick fixes (#30715)
6d95685 
* fix(material/select): close panel on detach output event (#30634)

* fix(material/autocomplete): allow overlay backdrop by setting hasBackdrop option (#30631)

Currently when we open the panel, backdrop is not allowed and is not inline with `mat-select`, `mat-menu`, etc. This fix will align autocomplete with those components and give an option to configure it.

Fixes #30457

---------

Co-authored-by: DavidACCarvalho <85346154+DavidACCarvalho@users.noreply.github.com>
Co-authored-by: Karan Mistry <karan.mistry@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/autocomplete target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-autocomplete): doesn't allow to have an overlay backdrop
3 participants
@mistrykaran91 @crisbeto @ThisUsernameIsAllreadyTaken