Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-angular-io): streamline directive and component metadata handling in dgeni #30661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mistrykaran91
Copy link
Contributor

Currently, docs is not grouped based on Components and Directives. This fix will separate those two sections.

Fixes #24093

@mistrykaran91 mistrykaran91 requested a review from a team as a code owner March 19, 2025 17:08
@mistrykaran91 mistrykaran91 requested a review from a team as a code owner March 20, 2025 09:31
@mistrykaran91 mistrykaran91 requested review from crisbeto and wagnermaciel and removed request for a team March 20, 2025 09:31
@angular-robot angular-robot bot added area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project area: cdk/overlay area: material/timepicker area: cdk/tree labels Mar 20, 2025
@mistrykaran91 mistrykaran91 force-pushed the fix/section-issue-between-directives-and-component branch from 55724c1 to 239922b Compare March 20, 2025 09:34
@angular-robot angular-robot bot removed area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project labels Mar 20, 2025
@mistrykaran91 mistrykaran91 force-pushed the fix/section-issue-between-directives-and-component branch 3 times, most recently from dd2f276 to 573efbe Compare March 20, 2025 09:50
@mistrykaran91 mistrykaran91 force-pushed the fix/section-issue-between-directives-and-component branch from 573efbe to 4f56add Compare March 20, 2025 09:57
@mistrykaran91
Copy link
Contributor Author

Not sure why other labels are added. I just rebased it with the main branch and pushed it. So it might be because of previous changes it added that. Should I another MR by closing this one and branching out from main again ?

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistrykaran91
Copy link
Contributor Author

mistrykaran91 commented Mar 22, 2025

@josephperrott, There's one more change in thescss file related to updating the font-size that I have made it.

… handling in dgeni

Currently, docs is not grouped based on Components and Directives. This fix will separate those two sections.

Fixes angular#24093
@mistrykaran91 mistrykaran91 force-pushed the fix/section-issue-between-directives-and-component branch from 379bdf8 to 8cd3206 Compare March 29, 2025 05:29
@mistrykaran91
Copy link
Contributor Author

mistrykaran91 commented Mar 29, 2025

@josephperrott @crisbeto, any idea when this can be merged ?

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs-bug(icon): MatIcon appears in the Directives section
2 participants