Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable type checking of host bindings #30691

Merged
merged 1 commit into from
Mar 23, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
# Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
# This file should be checked into version control along with the pnpm-lock.yaml file.
.npmrc=-2023857461
package.json=-1258556846
pnpm-lock.yaml=1977822002
package.json=1644151301
pnpm-lock.yaml=2107069472
pnpm-workspace.yaml=1711114604
yarn.lock=1826236985
yarn.lock=1593491870
2 changes: 2 additions & 0 deletions goldens/material/checkbox/index.api.md
Original file line number Diff line number Diff line change
@@ -35,6 +35,8 @@ export class MatCheckbox implements AfterViewInit, OnChanges, ControlValueAccess
indeterminateToChecked: string;
indeterminateToUnchecked: string;
};
// (undocumented)
protected _animationsDisabled: boolean;
ariaControls: string;
ariaDescribedby: string;
ariaExpanded: boolean;
36 changes: 18 additions & 18 deletions package.json
Original file line number Diff line number Diff line change
@@ -56,12 +56,12 @@
},
"version": "20.0.0-next.3",
"dependencies": {
"@angular/animations": "^20.0.0-next.0",
"@angular/common": "^20.0.0-next.0",
"@angular/compiler": "^20.0.0-next.0",
"@angular/core": "^20.0.0-next.0",
"@angular/forms": "^20.0.0-next.0",
"@angular/platform-browser": "^20.0.0-next.0",
"@angular/animations": "^20.0.0-next.3",
"@angular/common": "^20.0.0-next.3",
"@angular/compiler": "^20.0.0-next.3",
"@angular/core": "^20.0.0-next.3",
"@angular/forms": "^20.0.0-next.3",
"@angular/platform-browser": "^20.0.0-next.3",
"@types/google.maps": "^3.54.10",
"@types/youtube": "^0.1.0",
"rxjs": "^6.6.7",
@@ -70,19 +70,19 @@
"zone.js": "~0.15.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^20.0.0-next.0",
"@angular-devkit/core": "^20.0.0-next.0",
"@angular-devkit/schematics": "^20.0.0-next.0",
"@angular/bazel": "https://github.com/angular/bazel-builds.git#ba9ff4622e455b7cad2f983f5e611b9f46c57e86",
"@angular/build": "^20.0.0-next.0",
"@angular-devkit/build-angular": "^20.0.0-next.2",
"@angular-devkit/core": "^20.0.0-next.2",
"@angular-devkit/schematics": "^20.0.0-next.2",
"@angular/bazel": "https://github.com/angular/bazel-builds.git#54a0ac1bc77b58214a1c4d3cdcf167676ea621e4",
"@angular/build": "^20.0.0-next.2",
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#ec9df12469082e3cb087a9af55072dc2d833c73f",
"@angular/cli": "^20.0.0-next.0",
"@angular/compiler-cli": "^20.0.0-next.0",
"@angular/localize": "^20.0.0-next.0",
"@angular/cli": "^20.0.0-next.2",
"@angular/compiler-cli": "^20.0.0-next.3",
"@angular/localize": "^20.0.0-next.3",
"@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#1fa3a08b6a111de820da092799319ed47c058849",
"@angular/platform-browser-dynamic": "^20.0.0-next.0",
"@angular/platform-server": "^20.0.0-next.0",
"@angular/router": "^20.0.0-next.0",
"@angular/platform-browser-dynamic": "^20.0.0-next.3",
"@angular/platform-server": "^20.0.0-next.3",
"@angular/router": "^20.0.0-next.3",
"@babel/core": "^7.16.12",
"@babel/helper-explode-assignable-expression": "^7.18.6",
"@babel/helper-string-parser": "^7.22.5",
@@ -102,7 +102,7 @@
"@octokit/rest": "18.3.5",
"@rollup/plugin-commonjs": "^21.0.0",
"@rollup/plugin-node-resolve": "^13.1.3",
"@schematics/angular": "^20.0.0-next.0",
"@schematics/angular": "^20.0.0-next.2",
"@types/babel__core": "^7.1.18",
"@types/browser-sync": "^2.26.3",
"@types/fs-extra": "^9.0.13",
1,695 changes: 1,048 additions & 647 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/bazel-tsconfig-build.json
Original file line number Diff line number Diff line change
@@ -37,6 +37,8 @@
}
},
"angularCompilerOptions": {
"strictTemplates": true,
"typeCheckHostBindings": true,
"extendedDiagnostics": {
"defaultCategory": "error"
}
6 changes: 3 additions & 3 deletions src/cdk/drag-drop/directives/drop-list-shared.spec.ts
Original file line number Diff line number Diff line change
@@ -4994,7 +4994,7 @@ const DROP_ZONE_FIXTURE_TEMPLATE = `
[id]="dropZoneId"
[cdkDropListData]="items"
[cdkDropListDisabled]="dropDisabled()"
[cdkDropListLockAxis]="dropLockAxis()"
[cdkDropListLockAxis]="dropLockAxis()!"
(cdkDropListSorted)="sortedSpy($event)"
(cdkDropListDropped)="droppedSpy($event)">
<div
@@ -5165,7 +5165,7 @@ class DraggableInDropZoneWithContainer extends DraggableInDropZone {}
// https://github.com/angular/angular/pull/52515
@Component({
template: `
<div cdkDropList style="width: 100px; background: pink;" [cdkDropListLockAxis]="dropLockAxis()">
<div cdkDropList style="width: 100px; background: pink;" [cdkDropListLockAxis]="dropLockAxis()!">
@for (item of items; track item) {
<div
cdkDrag
@@ -5376,7 +5376,7 @@ const CONNECTED_DROP_ZONES_TEMPLATE = `
cdkDropList
#extraZone="cdkDropList"
[cdkDropListData]="extra"
[cdkDropListConnectedTo]="extraConnectedTo()"
[cdkDropListConnectedTo]="extraConnectedTo()!"
(cdkDropListDropped)="droppedSpy($event)"
(cdkDropListEntered)="enteredSpy($event)">
@for (item of extra; track item) {
2 changes: 1 addition & 1 deletion src/material/checkbox/checkbox.ts
Original file line number Diff line number Diff line change
@@ -115,7 +115,7 @@ export class MatCheckbox
_elementRef = inject<ElementRef<HTMLElement>>(ElementRef);
private _changeDetectorRef = inject(ChangeDetectorRef);
private _ngZone = inject(NgZone);
private _animationsDisabled = _animationsDisabled();
protected _animationsDisabled = _animationsDisabled();
private _options = inject<MatCheckboxDefaultOptions>(MAT_CHECKBOX_DEFAULT_OPTIONS, {
optional: true,
});
4 changes: 3 additions & 1 deletion src/tsconfig-legacy.json
Original file line number Diff line number Diff line change
@@ -28,6 +28,8 @@
"angularCompilerOptions": {
// This is needed so that test components are not AOT compiled. Ngtsc will
// not find an associated module for test components and error out.
"compileNonExportedClasses": false
"compileNonExportedClasses": false,
"typeCheckHostBindings": true,
"strictTemplates": true
}
}
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -43,6 +43,7 @@
},
"angularCompilerOptions": {
"strictTemplates": true,
"typeCheckHostBindings": true,
"extendedDiagnostics": {
"defaultCategory": "error"
}
Loading
Oops, something went wrong.
Loading
Oops, something went wrong.