-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19501. Skip tests that depend on SecurityManager if the JVM does not support it #7507
Open
stoty
wants to merge
5
commits into
apache:trunk
Choose a base branch
from
stoty:HADOOP-19501
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Can you please take a look @slfan1989 @cnauroth ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Due to JEP411 / JEP486 SecurityManager is either completely removed or has to be explicitly re-enabled in newer Java versions.
This patch adds assume() methods to those tests, so that they are skipped instead of erroring out when the
JVM does not let them set the SecurityManager.
A few tests have already been converted not to require SecurityManager, but the SecurityManager setting code
has not been removed. In those cases I have simply removed the SecurityManager-related calls.
How was this patch tested?
This was tested in my JDK23 branch with JDK23, and the standard CI checks for older Javas.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?