-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19488 fix the temporary directory creation on Windows #7511
Conversation
Use ACL-based permissions for Windows instead of POSIX permissions.
🎊 +1 overall
This message was automatically generated. |
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/RunJar.java
Show resolved
Hide resolved
Any additional feedback or comments? Thanks. |
The Jenkins CI run looks good - Logs - archive.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution @sjlee.
@sjlee @GauthamBanasandra Thanks for your contribution! Can we backport this pr to branch-3.4? |
…7511) * The Windows filesystem does not recognize the POSIX permissions, and it was causing the directory creation failure. * This PR checks if the filesystem does not support POSIX permissions, it switches to using the user-based, ACL-based permissions that work on Windows.
Use ACL-based permissions for Windows instead of POSIX permissions.
Description of PR
Fix Hadoop RunJar for Windows. The Windows filesystem does not recognize the POSIX permissions, and it was causing the directory creation failure. If the filesystem does not support POSIX permissions, switch to using the user-based, ACL-based permissions that work on Windows.
How was this patch tested?
I added a test to TestRunJar and ran it first to reproduce the bug on Windows. After I changed RunJar.java, I ran TestRunJar on Windows and confirmed it runs successfully.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?