[SPARK-51575][PYTHON] Combine Python Data Source pushdown & plan read workers #50340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wengh
changed the title
|
@cloud-fan @beliefer @allisonwang-db Please take a look at this follow up of Python Data Source filter pushdown PR #49961 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #49961
What changes were proposed in this pull request?
As pointed out by #49961 (comment), at the time of filter pushdown we already have enough information to also plan read partitions. So this PR changes the filter pushdown worker to also get partitions, reducing the number of exchanges between Python and Scala.
Changes:
plan_data_source_read.pythat is responsible for sending the partitions and the read function to JVM.data_source_pushdown_filters.py.Why are the changes needed?
To improve Python Data Source performance when filter pushdown configuration is enabled.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests in
test_python_datasource.pyWas this patch authored or co-authored using generative AI tooling?
No