Skip to content

Avoid to change the status of the response in StandardHostValve.java … #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rmannibucau
Copy link
Contributor

…if response is committed

main issue: you get a 500 in the access log whereas it was a 200 (for example)

@markt-asf
Copy link
Contributor

@markt-asf markt-asf closed this Jun 23, 2025
@rmannibucau
Copy link
Contributor Author

@markt-asf hmm, can you detail how it is unecessary since it happens in async exchanges? 🤔

@markt-asf
Copy link
Contributor

The check you've added is a duplicate of the first check that happens when the method in the if block is called.

@rmannibucau
Copy link
Contributor Author

@markt-asf hmm, you're right, wonder if it can be a timing issue so it would be helpful to set the "original status" in notes (or internal attributes) and check it in access log to not report a wrong status? any other idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants