Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid board change during compilation/upload #6106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid board change during compilation/upload #6106

wants to merge 1 commit into from

Conversation

facchinm
Copy link
Member

By threading the boardChange callback we can busy wait until
the compilation/upload phase has ended and change the board when done.

Fixes #6035

@facchinm
Avoid board change during compilation/upload
9da24d1 
By threading the boardChange callback we can busy wait until
the compilation/upload phase has ended and change the board when done.

Fixes arduino#6035
@mastrolinux mastrolinux added the in progress Work on this item is in progress label Mar 22, 2017
@facchinm facchinm added this to the Release 1.8.3 milestone Mar 22, 2017
@facchinm
Copy link
Member Author

@ArduinoBot build this please

@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-678-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-678-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-678-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-678-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-678-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@matthijskooijman
Copy link
Collaborator

This doesn't look like a very robust fix to me. Wouldn't it be better to refactor the verify/upload code to, when starting the verify/upload, collect all settings it needs and use these, regardless of any changes to the main settings?

@facchinm
Copy link
Member Author

Not very robust in fact, but refactoring the entire code from using the properties map into local variables could be longer than expected

@facchinm
Copy link
Member Author

facchinm commented Apr 4, 2017

A side effect of this patch is that bundled libraries' keywords.txt is parsed lately and the correct highlighting is not applied..

@facchinm facchinm added the editor-refactor Related to the refactoring of the Arduino IDE's editor component label Apr 4, 2017
@cmaglie cmaglie modified the milestones: Release 1.8.3, Next Jul 18, 2017
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-723-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-723-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-723-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-723-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-723-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@per1234 per1234 mentioned this pull request Apr 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
editor-refactor Related to the refactoring of the Arduino IDE's editor component in progress Work on this item is in progress
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
5 participants
@facchinm @ArduinoBot @matthijskooijman @cmaglie @mastrolinux