This repository was archived by the owner on Dec 19, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
/
Copy pathDefaultRequestDispatcherTest.cs
572 lines (488 loc) · 22.8 KB
/
DefaultRequestDispatcherTest.cs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
// Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Moq;
using Xunit;
namespace Microsoft.AspNetCore.Razor.Tools
{
public class DefaultRequestDispatcherTest
{
private static ServerRequest EmptyServerRequest => new ServerRequest(1, Array.Empty<RequestArgument>());
private static ServerResponse EmptyServerResponse => new CompletedServerResponse(
returnCode: 0,
utf8output: false,
output: string.Empty,
error: string.Empty);
[Fact]
public async Task AcceptConnection_ReadingRequestFails_ClosesConnection()
{
// Arrange
var stream = Mock.Of<Stream>();
var compilerHost = CreateCompilerHost();
var connectionHost = CreateConnectionHost();
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None);
var connection = CreateConnection(stream);
// Act
var result = await dispatcher.AcceptConnection(
Task.FromResult<Connection>(connection), accept: true, cancellationToken: CancellationToken.None);
// Assert
Assert.Equal(ConnectionResult.Reason.CompilationNotStarted, result.CloseReason);
}
/// <summary>
/// A failure to write the results to the client is considered a client disconnection. Any error
/// from when the build starts to when the write completes should be handled this way.
/// </summary>
[Fact]
public async Task AcceptConnection_WritingResultsFails_ClosesConnection()
{
// Arrange
var memoryStream = new MemoryStream();
await EmptyServerRequest.WriteAsync(memoryStream, CancellationToken.None).ConfigureAwait(true);
memoryStream.Position = 0;
var stream = new Mock<Stream>(MockBehavior.Strict);
stream
.Setup(x => x.ReadAsync(It.IsAny<byte[]>(), It.IsAny<int>(), It.IsAny<int>(), It.IsAny<CancellationToken>()))
.Returns((byte[] array, int start, int length, CancellationToken ct) => memoryStream.ReadAsync(array, start, length, ct));
var connection = CreateConnection(stream.Object);
var compilerHost = CreateCompilerHost(c =>
{
c.ExecuteFunc = (req, ct) =>
{
return EmptyServerResponse;
};
});
var connectionHost = CreateConnectionHost();
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None);
// Act
// We expect WriteAsync to fail because the mock stream doesn't have a corresponding setup.
var connectionResult = await dispatcher.AcceptConnection(
Task.FromResult<Connection>(connection), accept: true, cancellationToken: CancellationToken.None);
// Assert
Assert.Equal(ConnectionResult.Reason.ClientDisconnect, connectionResult.CloseReason);
Assert.Null(connectionResult.KeepAlive);
}
/// <summary>
/// Ensure the Connection correctly handles the case where a client disconnects while in the
/// middle of executing a request.
/// </summary>
[Fact]
public async Task AcceptConnection_ClientDisconnectsWhenExecutingRequest_ClosesConnection()
{
// Arrange
var connectionHost = Mock.Of<ConnectionHost>();
// Fake a long running task here that we can validate later on.
var buildTaskSource = new TaskCompletionSource<bool>();
var buildTaskCancellationToken = default(CancellationToken);
var compilerHost = CreateCompilerHost(c =>
{
c.ExecuteFunc = (req, ct) =>
{
Task.WaitAll(buildTaskSource.Task);
return EmptyServerResponse;
};
});
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None);
var readyTaskSource = new TaskCompletionSource<bool>();
var disconnectTaskSource = new TaskCompletionSource<bool>();
var connectionTask = CreateConnectionWithEmptyServerRequest(c =>
{
c.WaitForDisconnectAsyncFunc = (ct) =>
{
buildTaskCancellationToken = ct;
readyTaskSource.SetResult(true);
return disconnectTaskSource.Task;
};
});
var handleTask = dispatcher.AcceptConnection(
connectionTask, accept: true, cancellationToken: CancellationToken.None);
// Wait until WaitForDisconnectAsync task is actually created and running.
await readyTaskSource.Task.ConfigureAwait(false);
// Act
// Now simulate a disconnect by the client.
disconnectTaskSource.SetResult(true);
var connectionResult = await handleTask;
buildTaskSource.SetResult(true);
// Assert
Assert.Equal(ConnectionResult.Reason.ClientDisconnect, connectionResult.CloseReason);
Assert.Null(connectionResult.KeepAlive);
Assert.True(buildTaskCancellationToken.IsCancellationRequested);
}
[Fact]
public async Task AcceptConnection_AcceptFalse_RejectsBuildRequest()
{
// Arrange
var stream = new TestableStream();
await EmptyServerRequest.WriteAsync(stream.ReadStream, CancellationToken.None);
stream.ReadStream.Position = 0;
var connection = CreateConnection(stream);
var connectionHost = CreateConnectionHost();
var compilerHost = CreateCompilerHost();
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None);
// Act
var connectionResult = await dispatcher.AcceptConnection(
Task.FromResult<Connection>(connection), accept: false, cancellationToken: CancellationToken.None);
// Assert
Assert.Equal(ConnectionResult.Reason.CompilationNotStarted, connectionResult.CloseReason);
stream.WriteStream.Position = 0;
var response = await ServerResponse.ReadAsync(stream.WriteStream).ConfigureAwait(false);
Assert.Equal(ServerResponse.ResponseType.Rejected, response.Type);
}
[Fact]
public async Task AcceptConnection_ShutdownRequest_ReturnsShutdownResponse()
{
// Arrange
var stream = new TestableStream();
await ServerRequest.CreateShutdown().WriteAsync(stream.ReadStream, CancellationToken.None);
stream.ReadStream.Position = 0;
var connection = CreateConnection(stream);
var connectionHost = CreateConnectionHost();
var compilerHost = CreateCompilerHost();
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None);
// Act
var connectionResult = await dispatcher.AcceptConnection(
Task.FromResult<Connection>(connection), accept: true, cancellationToken: CancellationToken.None);
// Assert
Assert.Equal(ConnectionResult.Reason.ClientShutdownRequest, connectionResult.CloseReason);
stream.WriteStream.Position = 0;
var response = await ServerResponse.ReadAsync(stream.WriteStream).ConfigureAwait(false);
Assert.Equal(ServerResponse.ResponseType.Shutdown, response.Type);
}
[Fact]
public async Task AcceptConnection_ConnectionHostThrowsWhenConnecting_ClosesConnection()
{
// Arrange
var connectionHost = new Mock<ConnectionHost>(MockBehavior.Strict);
connectionHost.Setup(c => c.WaitForConnectionAsync(It.IsAny<CancellationToken>())).Throws(new Exception());
var compilerHost = CreateCompilerHost();
var dispatcher = new DefaultRequestDispatcher(connectionHost.Object, compilerHost, CancellationToken.None);
var connection = CreateConnection(Mock.Of<Stream>());
// Act
var connectionResult = await dispatcher.AcceptConnection(
Task.FromResult<Connection>(connection), accept: true, cancellationToken: CancellationToken.None);
// Assert
Assert.Equal(ConnectionResult.Reason.CompilationNotStarted, connectionResult.CloseReason);
Assert.Null(connectionResult.KeepAlive);
}
[Fact]
public async Task AcceptConnection_ClientConnectionThrowsWhenConnecting_ClosesConnection()
{
// Arrange
var compilerHost = CreateCompilerHost();
var connectionHost = CreateConnectionHost();
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None);
var connectionTask = Task.FromException<Connection>(new Exception());
// Act
var connectionResult = await dispatcher.AcceptConnection(
connectionTask, accept: true, cancellationToken: CancellationToken.None);
// Assert
Assert.Equal(ConnectionResult.Reason.CompilationNotStarted, connectionResult.CloseReason);
Assert.Null(connectionResult.KeepAlive);
}
[Fact]
public async Task Dispatcher_ClientConnectionThrowsWhenExecutingRequest_ClosesConnection()
{
// Arrange
var called = false;
var connectionTask = CreateConnectionWithEmptyServerRequest(c =>
{
c.WaitForDisconnectAsyncFunc = (ct) =>
{
called = true;
throw new Exception();
};
});
var compilerHost = CreateCompilerHost();
var connectionHost = CreateConnectionHost();
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None);
// Act
var connectionResult = await dispatcher.AcceptConnection(
connectionTask, accept: true, cancellationToken: CancellationToken.None);
// Assert
Assert.True(called);
Assert.Equal(ConnectionResult.Reason.ClientException, connectionResult.CloseReason);
Assert.Null(connectionResult.KeepAlive);
}
[Fact]
public void Dispatcher_NoConnections_HitsKeepAliveTimeout()
{
// Arrange
var keepAlive = TimeSpan.FromSeconds(3);
var compilerHost = CreateCompilerHost();
var connectionHost = new Mock<ConnectionHost>();
connectionHost
.Setup(x => x.WaitForConnectionAsync(It.IsAny<CancellationToken>()))
.Returns(new TaskCompletionSource<Connection>().Task);
var eventBus = new TestableEventBus();
var dispatcher = new DefaultRequestDispatcher(connectionHost.Object, compilerHost, CancellationToken.None, eventBus, keepAlive);
var startTime = DateTime.Now;
// Act
dispatcher.Run();
// Assert
Assert.True(eventBus.HitKeepAliveTimeout);
}
/// <summary>
/// Ensure server respects keep alive and shuts down after processing a single connection.
/// </summary>
[Fact]
public void Dispatcher_ProcessSingleConnection_HitsKeepAliveTimeout()
{
// Arrange
var connectionTask = CreateConnectionWithEmptyServerRequest();
var keepAlive = TimeSpan.FromSeconds(1);
var compilerHost = CreateCompilerHost(c =>
{
c.ExecuteFunc = (req, ct) =>
{
return EmptyServerResponse;
};
});
var connectionHost = CreateConnectionHost(connectionTask, new TaskCompletionSource<Connection>().Task);
var eventBus = new TestableEventBus();
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None, eventBus, keepAlive);
// Act
dispatcher.Run();
// Assert
Assert.Equal(1, eventBus.CompletedCount);
Assert.True(eventBus.LastProcessedTime.HasValue);
Assert.True(eventBus.HitKeepAliveTimeout);
}
/// <summary>
/// Ensure server respects keep alive and shuts down after processing multiple connections.
/// </summary>
[Fact]
public void Dispatcher_ProcessMultipleConnections_HitsKeepAliveTimeout()
{
// Arrange
var count = 5;
var list = new List<Task<Connection>>();
for (var i = 0; i < count; i++)
{
var connectionTask = CreateConnectionWithEmptyServerRequest();
list.Add(connectionTask);
}
list.Add(new TaskCompletionSource<Connection>().Task);
var connectionHost = CreateConnectionHost(list.ToArray());
var compilerHost = CreateCompilerHost(c =>
{
c.ExecuteFunc = (req, ct) =>
{
return EmptyServerResponse;
};
});
var keepAlive = TimeSpan.FromSeconds(1);
var eventBus = new TestableEventBus();
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None, eventBus, keepAlive);
// Act
dispatcher.Run();
// Assert
Assert.Equal(count, eventBus.CompletedCount);
Assert.True(eventBus.LastProcessedTime.HasValue);
Assert.True(eventBus.HitKeepAliveTimeout);
}
/// <summary>
/// Ensure server respects keep alive and shuts down after processing simultaneous connections.
/// </summary>
[Fact]
public async Task Dispatcher_ProcessSimultaneousConnections_HitsKeepAliveTimeout()
{
// Arrange
var totalCount = 2;
var readySource = new TaskCompletionSource<bool>();
var list = new List<TaskCompletionSource<bool>>();
var connectionHost = new Mock<ConnectionHost>();
connectionHost
.Setup(x => x.WaitForConnectionAsync(It.IsAny<CancellationToken>()))
.Returns((CancellationToken ct) =>
{
if (list.Count < totalCount)
{
var source = new TaskCompletionSource<bool>();
var connectionTask = CreateConnectionWithEmptyServerRequest(c =>
{
// Keep the connection active until we decide to end it.
c.WaitForDisconnectAsyncFunc = _ => source.Task;
});
list.Add(source);
return connectionTask;
}
readySource.SetResult(true);
return new TaskCompletionSource<Connection>().Task;
});
var compilerHost = CreateCompilerHost(c =>
{
c.ExecuteFunc = (req, ct) =>
{
return EmptyServerResponse;
};
});
var eventBus = new TestableEventBus();
var completedCompilations = 0;
var allCompilationsComplete = new TaskCompletionSource<bool>();
eventBus.CompilationComplete += (obj, args) =>
{
if (++completedCompilations == totalCount)
{
// All compilations have completed.
allCompilationsComplete.SetResult(true);
}
};
var keepAlive = TimeSpan.FromSeconds(1);
var dispatcherTask = Task.Run(() =>
{
var dispatcher = new DefaultRequestDispatcher(connectionHost.Object, compilerHost, CancellationToken.None, eventBus, keepAlive);
dispatcher.Run();
});
// Wait for all connections to be created.
await readySource.Task;
// Wait for all compilations to complete.
await allCompilationsComplete.Task;
// Now allow all the connections to be disconnected.
foreach (var source in list)
{
source.SetResult(true);
}
// Act
// Now dispatcher should be in an idle state with no active connections.
await dispatcherTask;
// Assert
Assert.False(eventBus.HasDetectedBadConnection);
Assert.Equal(totalCount, eventBus.CompletedCount);
Assert.True(eventBus.LastProcessedTime.HasValue, "LastProcessedTime should have had a value.");
Assert.True(eventBus.HitKeepAliveTimeout, "HitKeepAliveTimeout should have been hit.");
}
[Fact]
public void Dispatcher_ClientConnectionThrows_BeginsShutdown()
{
// Arrange
var listenCancellationToken = default(CancellationToken);
var firstConnectionTask = CreateConnectionWithEmptyServerRequest(c =>
{
c.WaitForDisconnectAsyncFunc = (ct) =>
{
listenCancellationToken = ct;
return Task.Delay(Timeout.Infinite, ct).ContinueWith<Connection>(_ => null);
};
});
var secondConnectionTask = CreateConnectionWithEmptyServerRequest(c =>
{
c.WaitForDisconnectAsyncFunc = (ct) => throw new Exception();
});
var compilerHost = CreateCompilerHost();
var connectionHost = CreateConnectionHost(
firstConnectionTask,
secondConnectionTask,
new TaskCompletionSource<Connection>().Task);
var keepAlive = TimeSpan.FromSeconds(10);
var eventBus = new TestableEventBus();
var dispatcher = new DefaultRequestDispatcher(connectionHost, compilerHost, CancellationToken.None, eventBus, keepAlive);
// Act
dispatcher.Run();
// Assert
Assert.True(eventBus.HasDetectedBadConnection);
Assert.True(listenCancellationToken.IsCancellationRequested);
}
private static TestableConnection CreateConnection(Stream stream, string identifier = null)
{
return new TestableConnection(stream, identifier ?? "identifier");
}
private static async Task<Connection> CreateConnectionWithEmptyServerRequest(Action<TestableConnection> configureConnection = null)
{
var memoryStream = new MemoryStream();
await EmptyServerRequest.WriteAsync(memoryStream, CancellationToken.None);
memoryStream.Position = 0;
var connection = CreateConnection(memoryStream);
configureConnection?.Invoke(connection);
return connection;
}
private static ConnectionHost CreateConnectionHost(params Task<Connection>[] connections)
{
var host = new Mock<ConnectionHost>();
if (connections.Length > 0)
{
var index = 0;
host
.Setup(x => x.WaitForConnectionAsync(It.IsAny<CancellationToken>()))
.Returns((CancellationToken ct) => connections[index++]);
}
return host.Object;
}
private static TestableCompilerHost CreateCompilerHost(Action<TestableCompilerHost> configureCompilerHost = null)
{
var compilerHost = new TestableCompilerHost();
configureCompilerHost?.Invoke(compilerHost);
return compilerHost;
}
private class TestableCompilerHost : CompilerHost
{
internal Func<ServerRequest, CancellationToken, ServerResponse> ExecuteFunc;
public override ServerResponse Execute(ServerRequest request, CancellationToken cancellationToken)
{
if (ExecuteFunc != null)
{
return ExecuteFunc(request, cancellationToken);
}
return EmptyServerResponse;
}
}
private class TestableConnection : Connection
{
internal Func<CancellationToken, Task> WaitForDisconnectAsyncFunc;
public TestableConnection(Stream stream, string identifier)
{
Stream = stream;
Identifier = identifier;
WaitForDisconnectAsyncFunc = ct => Task.Delay(Timeout.Infinite, ct);
}
public override Task WaitForDisconnectAsync(CancellationToken cancellationToken)
{
return WaitForDisconnectAsyncFunc(cancellationToken);
}
}
private class TestableStream : Stream
{
internal readonly MemoryStream ReadStream = new MemoryStream();
internal readonly MemoryStream WriteStream = new MemoryStream();
public override bool CanRead => true;
public override bool CanSeek => false;
public override bool CanWrite => true;
public override long Length { get { throw new NotImplementedException(); } }
public override long Position
{
get { throw new NotImplementedException(); }
set { throw new NotImplementedException(); }
}
public override void Flush()
{
}
public override int Read(byte[] buffer, int offset, int count)
{
return ReadStream.Read(buffer, offset, count);
}
public override Task<int> ReadAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
{
return ReadStream.ReadAsync(buffer, offset, count, cancellationToken);
}
public override long Seek(long offset, SeekOrigin origin)
{
throw new NotImplementedException();
}
public override void SetLength(long value)
{
throw new NotImplementedException();
}
public override void Write(byte[] buffer, int offset, int count)
{
WriteStream.Write(buffer, offset, count);
}
public override Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
{
return WriteStream.WriteAsync(buffer, offset, count, cancellationToken);
}
}
}
}