Allow string value for select for enhanced query request #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
requested changes
Feb 26, 2025
...d/src/test/java/software/amazon/awssdk/enhanced/dynamodb/model/QueryEnhancedRequestTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
314
to
319
| /** | ||
| * Determines the attributes to be returned in the result. See {@link Select} for examples and constraints. | ||
| * If not found, returns {@link Select#UNKNOWN_TO_SDK_VERSION}. | ||
| * @param select the selection criteria as a string | ||
| * @return a builder of this type | ||
| */ |
There was a problem hiding this comment.
nit: this API doc seems to be copied from a getter, not setter? Can we update it
| * @return a builder of this type | ||
| */ | ||
| public Builder select(String select) { | ||
| this.select = Select.fromValue(select); |
There was a problem hiding this comment.
I think we need to change the select variable to string and pass it to the low level client to make it actually work. If customers pass an unsupported string, it'd be initialized as UNKNOWN_TO_SDK_VERSION
There was a problem hiding this comment.
Changed the implementation accordingly, please re-check - thanks!
...-enhanced/src/it/java/software/amazon/awssdk/enhanced/dynamodb/ScanQueryIntegrationTest.java
Outdated
Show resolved
Hide resolved
zoewangg
requested changes
Mar 14, 2025
...anced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/model/QueryEnhancedRequest.java
Outdated
Show resolved
Hide resolved
...anced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/model/QueryEnhancedRequest.java
Outdated
Show resolved
Hide resolved
…necessary conversion from selectAsString().
zoewangg
approved these changes
Mar 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enum
Expected behaviour: allow adding a String instead of Select enum value in the projection expression and validate the options against the low level DynamoDB enum.
Motivation and Context
#5547
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License