Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

区分问题和答案文件夹, 用户指定问题时, 文件放到问题文件夹; 增加了solve #{id}的功能 #18

Merged
merged 10 commits into from
Feb 5, 2020

Conversation

songyzh
Copy link
Contributor

@songyzh songyzh commented Feb 2, 2020

方便用户做题/看答案
增加solve #{id}功能, 方便把problem中的文件转移到solution中

@songyzh songyzh changed the title 区分问题和答案文件夹, 用户指定问题时, 文件放到问题文件夹 区分问题和答案文件夹, 用户指定问题时, 文件放到问题文件夹; 增加了solve #{id}的功能 Feb 2, 2020
Copy link
Owner

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

src/main.rs Outdated
@@ -18,34 +20,48 @@ fn main() {
loop {
println!("Please enter a frontend problem id, or \"random\" to generate a random one.");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a message to explain the solve $i command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 0d72e62

src/main.rs Outdated
Comment on lines 55 to 58
if solved_ids.contains(&id) {
println!(
"The problem you chose is invalid (the problem may have been initialized \
or may have no rust version)."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the error message seems not match the condition that the problem has been solved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@songyzh
Copy link
Contributor Author

songyzh commented Feb 4, 2020

@aylei fixed, review plz, thx!

Copy link
Owner

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aylei aylei merged commit 955822d into aylei:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants