wasi-nn: Update WIT #11041
Merged
wasi-nn: Update WIT #11041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
requested review from
abrown
and removed request for
a team and
fitzgen
abrown
approved these changes
Jun 27, 2025
There was a problem hiding this comment.
@rahulchaphalkar walked me through running all the wasi-nn tests with all of the various backends and this PR does not appear to change any results. Adapting this implementation to WITX is getting even more awkward; I really think we should consider removing the WITX half of this crate at some point soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set-input,get-outputfunctions, modifiescomputeto accept Vec ofNamedTensorparameter representing input tensors, and return Vec ofNamedTensorrepresenting output tensor.computehandles both wit and witx depending on if input tensors in form of Vec is provided.set-input,get-outputfunctions remain in the code for WITX support.