Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): Run sessions tests with disabled web security #5273

Merged
merged 8 commits into from
Mar 4, 2025

Conversation

jacekradko
Copy link
Member

@jacekradko jacekradko commented Mar 3, 2025

Description

Allow for the production sessions test to run with --disable-web-security to get around the CORS mismatch caused by port numbers used in tests

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: dfaeb4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 5:19pm

@jacekradko jacekradko changed the title fix(integration): run sessions tests with disabled web security fix(integration): Run sessions tests with disabled web security Mar 3, 2025
@jacekradko jacekradko marked this pull request as ready for review March 3, 2025 20:02
@jacekradko jacekradko changed the title fix(integration): Run sessions tests with disabled web security fix(repo): Run sessions tests with disabled web security Mar 3, 2025
@jacekradko jacekradko enabled auto-merge (squash) March 4, 2025 17:23
@jacekradko jacekradko merged commit e05f275 into main Mar 4, 2025
30 checks passed
@jacekradko jacekradko deleted the fix/sessions-tests-insecure branch March 4, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants