feat(clerk-js): Allow Environment init with defaults #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ecf070a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Marking it Ready for Review to get some feedback on the approach |
jacekradko
requested review from
nikosdouvlis,
panteliselef,
dstaley and
brkalow
9 tasks
jacekradko
changed the title
panteliselef
approved these changes
Mar 18, 2025
LekoArts
reviewed
Mar 18, 2025
Co-authored-by: Lennart <lekoarts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary: This pull request introduces a feature that enables the initialization of the Clerk.js environment with default settings. By allowing defaults during environment setup, it allows us to instantiate the EnvironmentResource class even if the
/v1/environmentendpoint is downKey Changes:
• Modified the environment initialization process to support default parameters.
• Updated relevant documentation to reflect the new initialization capabilities.
• Added tests to ensure the default initialization functions as intended.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change