-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(repo): Handle errors in E2E proxy server #5328
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
8c07b3a
to
3c11956
Compare
If the test assertions require it, then yes. If it can be either I personally (in my own projects) prefer to use the build + serve option as it's faster, more stable/reliable, and ensures that it works in "production". Sometimes there are differences between dev and build behavior and I rather test against what is shown live.
Keeping us auto-updated is a good thing as we can react to (un)intended changes that might break something on our end. As a user I expect it to always work with the latest version of Next.js so we should test this. And us having to manually updated pinned versions (even with bots) won't work, we'll forget it. |
Description
Long story short... crashing the proxy server is bad.
Long story long...
Background
Our integration tests run against app servers using Next.js in dev mode, meaning Hot Module Replacement (HMR) is enabled. In some tests, we route traffic through a proxy server, which unexpectedly crashed when handling the
/_next/webpack-hmr
route.Why? Because our proxy server wasn’t handling errors properly.
What Changed?
Open Questions
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change