Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Show unverified fields if any when ToS is enabled #5404

Conversation

octoper
Copy link
Member

@octoper octoper commented Mar 20, 2025

Description

This PR fixes an issue where not showing showing the email address input field if it was unverified and ToS was enabled

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: cf3dc49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 3:56pm

@octoper octoper force-pushed the vaggelis/user-1299-social-sign-up-with-unverified-email-dont-play-well-with branch from dc210fc to 3ec78ef Compare March 20, 2025 15:25
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test ?

@octoper
Copy link
Member Author

octoper commented Mar 20, 2025

@panteliselef Yup, already on it 👍

Co-authored-by: panteliselef <panteliselef@outlook.com>
@octoper octoper enabled auto-merge (squash) March 20, 2025 16:03
@octoper octoper merged commit f59a90b into main Mar 20, 2025
30 checks passed
@octoper octoper deleted the vaggelis/user-1299-social-sign-up-with-unverified-email-dont-play-well-with branch March 20, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants