rpc: remove DRPC dependency from Peer and Connection generics
#148609
+109
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthumuluru-crdb
changed the title
Peer and Connection generics
|
This change is |
cthumuluru-crdb
force-pushed
the
drpc-peer-pr2
branch
2 times, most recently
from
4da8d25 to
0ee4f1e
Compare
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
tbg
approved these changes
Jun 24, 2025
cthumuluru-crdb
force-pushed
the
drpc-peer-pr2
branch
from
f879fbe to
5e2950d
Compare
|
@shubhamdhama, if you have any additional comments on this PR drop a comment here and I'll address them in a separate commit. |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
148609: rpc: remove DRPC dependency from `Peer` and `Connection` generics r=cthumuluru-crdb a=cthumuluru-crdb Although `Peer` and `Connection` are generic and intended to support both gRPC and DRPC connections, the current implementation has a hardcoded dependency on DRPC. As a result, a DRPC connection is always dialed, regardless of the intended type. This PR removes the direct dependency on DRPC, allowing the appropriate connection type (gRPC or DRPC) to be used based on the generic parameter. Epic: CRDB-48923 Fixes: none Release note: none Co-authored-by: Chandra Thumuluru <chandra.thumuluru@cockroachlabs.com>
This is a follow-up to cockroachdb#145195, where we extracted KVBatch from the Internal service. Here, we do the same with RangeFeed. The TL;DR is that smaller services are easier to maintain and can be more smoothly migrated to DRPC. We also enable this service on the DRPC server. This is controlled by `rpc.experimental_drpc.enabled` (off by default). This change is part of a series and is similar to: cockroachdb#146926 Note: This only registers the service; the client is not updated to use the DRPC client, so this service will not have any functional effect. Epic: CRDB-48925 Release note: None
Although `Peer` and `Connection` are generic and intended to support both gRPC and DRPC connections, the current implementation has a hardcoded dependency on DRPC. As a result, a DRPC connection is always dialed, regardless of the intended type. This PR removes the direct dependency on DRPC, allowing the appropriate connection type (gRPC or DRPC) to be used based on the generic parameter. Epic: CRDB-48923 Fixes: none Release note: none
cthumuluru-crdb
force-pushed
the
drpc-peer-pr2
branch
from
5e2950d to
5be50d0
Compare
|
Canceled. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
PeerandConnectionare generic and intended to support both gRPC and DRPC connections, the current implementation has a hardcoded dependency on DRPC. As a result, a DRPC connection is always dialed, regardless of the intended type. This PR removes the direct dependency on DRPC, allowing the appropriate connection type (gRPC or DRPC) to be used based on the generic parameter.Epic: CRDB-48923
Fixes: none
Release note: none