Skip to content

Fix flaky ExceptionHandlerTest #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix flaky ExceptionHandlerTest #379

merged 1 commit into from
Oct 6, 2022

Conversation

molly-moen
Copy link
Contributor

We were occasionally seeing this test fail because the Logger instance was being garbage collected. The fix for this is to mock LoggerUtils in this test instead.

@molly-moen molly-moen requested a review from a team October 6, 2022 16:46
sanchitmalhotra126
sanchitmalhotra126 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@sanchitmalhotra126 sanchitmalhotra126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this!

@molly-moen molly-moen merged commit 946f709 into main Oct 6, 2022
@molly-moen molly-moen deleted the molly-flaky-exception-test branch October 6, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddiedierker maddiedierker maddiedierker approved these changes

@sanchitmalhotra126 sanchitmalhotra126 sanchitmalhotra126 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@molly-moen @maddiedierker @sanchitmalhotra126