increase neighborhood time limit to 120s #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the time limit for Java Lab neighborhood levels from 90 sec to 120 sec.
This is in response to a request from a user who wrote a program that took more than 90 seconds to run to completion at this level for which students were assigned to create a design on a 32x32 grid:
jira ticket - Java Lab - Increase Neighborhood time limit to 2 minutes
Slack discussion
Before the time limit was increased:
After the time limit was increased: (~ 1 min 45 sec to complete)
Follow-up
There was discussion in the Slack thread that a longer-term solution is to try to optimize the way signals are sent.