Add NO_AUDIO signal to theater #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
approved these changes
Jan 11, 2023
| ``` | ||
| TARGET_BRANCH=mybranch ENVIRONMENT_TYPE=development cicd/2-cicd/deploy-cicd.sh | ||
| ``` | ||
| Steps |
There was a problem hiding this comment.
Thanks for adding this!
molly-moen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until this PR is deployed.
This PR adds a
NO_AUDIOsignal to theater if there is no audio, replacing our previous behavior of sending an empty audio file. This empty file did not work for Safari, so Theater projects without audio on Safari would not run.I also updated our dev deploy instructions to link out to our AWS login instructions, as that tripped me up when I deployed a dev javabuilder instance for the first time in months.