fix case of subdomain term

[cat5inthecradle]

I'm nearly certain this variable rename would be a no-op on the actual template.

[Hamms]

one nit, otherwise LGTM; thanks for picking this up so quickly!

As an aside, there is also an argument to be made that the phrase "Base Domain Name" is a bit confusing. Technically, something like code.org is just called a "base domain", and consists of two parts: the "domain name" (code) and the "top-level domain" (org). We're kind of smashing together the two different-but-related concepts of "base domain" and "domain name" to produce a phrase which I think we consistently use to refer to just one of those concepts. Either way, though, that's a discussion for another PR.

[Hamms]

nit:

Suggested change

	Description: Sub domain name for javabuilder service (e.g. 'javabuilder' in 'javabuilder.code.org').
	Description: Subdomain name for javabuilder service (e.g. 'javabuilder' in 'javabuilder.code.org').

Looks like the corresponding line in 3-app already got updated!

[cat5inthecradle]

As an aside, there is also an argument to be made that the phrase "Base Domain Name" is a bit confusing. Technically, something like code.org is just called a "base domain", and consists of two parts: the "domain name" (code) and the "top-level domain" (org). We're kind of smashing together the two different-but-related concepts of "base domain" and "domain name" to produce a phrase which I think we consistently use to refer to just one of those concepts. Either way, though, that's a discussion for another PR.

I don't know what the best term is here for domain + tld, I avoided DomainName to make it more clear that it wouldn't include a subdomain. We're using BaseDomain in three ways:

1. To identify when we're using 'dev-code.org' (these could be refactored away I think)
2. To identify the hosted zone (nameserver) for new dns records (could be refactored to use hostedzoneID, which we already require)
3. To assist with the creation of certain urls like subdomain-http.domain.tld and subdomain-content.domain.tld (these could be refactored to service-subdomain.domain.tld or service.subdomain.domain.tld
4. related, we create alarms named subdomain_alarm_name, so having the subdomain distinct is also useful.

Edit-to-add: Changing those additional urls, alarms, etc, would probably break continuity with some existing logs and data, and would at the very least need to be strategically timed to ensure we have useful data for the school year.

[Hamms]

Best term I'd say for domain + tld is just BaseDomain. In general:

TopLevelDomain = 'org'
DomainName = 'code'
Subdomains = ['studio']
BaseDomain = [DomainName, TopLevelDomain].join('.')
Hostname = [*Subdomains, BaseDomain].join('.')

[sureshc]

nit - feature branch name is way too hilarious

[cat5inthecradle]

discussion of whether we need to maintain log/alarm continuity: https://codedotorg.slack.com/archives/C03DBDN67B7/p1675465733136349