Skip to content

Commit c3bf5ef

Browse files
authored
Merge pull request #4 from sarbbottam/fix/heading
fix(heading): usage and order
2 parents ec904f8 + 3d98bb4 commit c3bf5ef

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/step-1/Introduction.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class Introduction extends Component {
77
<div className="introduction">
88
<h1>1. Introduction</h1>
99
<p>In this codelabs, you will be learning what is a progressive web application, how it works and how to build one.</p>
10-
<p><b>What is a Progressive Web Application?</b></p>
10+
<h2>What is a Progressive Web Application?</h2>
1111
<p>A progressive web application (pwa) uses modern web technologies to deliver native app like experience even when user is offline. Features are.</p>
1212
<ul className="pwa">
1313
<li><b>Responsive</b> - Fits any form factor and works across the devices.</li>
@@ -19,17 +19,17 @@ class Introduction extends Component {
1919
<li><b>Installable</b> - Add to homescreen.</li>
2020
<li><b>Linkable</b> - Easy to share.</li>
2121
</ul>
22-
23-
<p><b>What you will learn</b></p>
22+
23+
<h2>What you will learn</h2>
2424
<ul>
2525
<li>App Shell Architecture</li>
2626
<li>Service Worker and its lifecycle</li>
2727
<li>Caching the resources</li>
2828
<li>Offline</li>
2929
<li>Native app like features.</li>
3030
</ul>
31-
32-
<p><b>Things you need</b></p>
31+
32+
<h2>Things you need</h2>
3333
<ul>
3434
<li><a href="https://www.google.com/chrome/browser/desktop/" target="_blank">Chrome Browser</a> 46 or above</li>
3535
<li>Text Editor</li>

src/step-3/AppShell.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@ class AppShell extends Component {
3737
<h1>App Shell Architecture</h1>
3838
<p>An app shell architecture is minimal level <span className="highlight bold no--bg">HTML, CSS, Javascript</span> required to power the application user interface.</p>
3939

40-
<h3>Components for App Shell</h3>
40+
<h2>Components for App Shell</h2>
4141
<ul className="">
4242
<li>Header with icon and title</li>
4343
<li>Menu with overlay</li>
4444
<li>Main section</li>
4545
</ul>
4646

47-
<h3>HTML for App Shell</h3>
47+
<h2>HTML for App Shell</h2>
4848

4949
<Highlight lang='html' value={appShellCode} />
5050

@@ -73,7 +73,7 @@ class AppShell extends Component {
7373

7474
<p>See the full result <a href="http://www.webpagetest.org/result/161021_1H_G6C/">here</a>.</p>
7575

76-
<h3>Applications using app shell in production</h3>
76+
<h2>Applications using app shell in production</h2>
7777
<ul>
7878
<li><a href="https://www.google.com/inbox/" target="_blank">Inbox</a> by Gmail</li>
7979
<li><a href="flipkart.com" target="_blank">Flipkar Lite</a></li>

src/step-7/Finish.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class Finish extends Component {
1212
<div>
1313
<h1>Deploy</h1>
1414
<p>The final step of this codelabs is deploying our github cards with HTTPS server.</p>
15-
<h3>Follow the below steps.</h3>
15+
<h2>Follow the below steps.</h2>
1616
<p><span className="highlight bold no--bg">Step 1</span> - Install surge via npm.</p>
1717
<Highlight lang="bash" value={surgeInstall} />
1818

@@ -24,7 +24,7 @@ class Finish extends Component {
2424

2525
<p>After successful deployment, you will get an url in your terminal. Copy it and open in your desktop and mobile browsers :D</p>
2626

27-
<h3>What next?</h3>
27+
<h2>What next?</h2>
2828
<p>Everything is perfect, except the deployed site is loading in HTTP unless we change the url to HTTPS. So lets fix it by forcing HTTP to redirect to HTTPS.</p>
2929

3030
<Highlight lang="bash" value={surgeDeployHTTPS} />

0 commit comments

Comments
 (0)