Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix tests after smarter getPrivateMethodInvoker() return #9491

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

paulbalandan
Copy link
Member

Description
Fixes the following phpstan errors after having smarter return type for getPrivateMethodInvoker().

------ ------------------------------------ 
  Line   tests/system/ControllerTest.php     
 ------ ------------------------------------ 
  :98    Result of closure (void) is used.   
         🪪  callable.void                   
         ✏️  tests/system/ControllerTest.php  
 ------ ------------------------------------ 

 ------ ------------------------------------------------------- 
  Line   tests/system/Database/ConfigTest.php                   
 ------ ------------------------------------------------------- 
  :171   Unreachable statement - code above always terminates.  
         🪪  deadCode.unreachable                               
         ✏️  tests/system/Database/ConfigTest.php               
  :211   Unreachable statement - code above always terminates.  
         🪪  deadCode.unreachable                               
         ✏️  tests/system/Database/ConfigTest.php               
 ------ ------------------------------------------------------- 

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Mar 15, 2025
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now I get it, I commented about it in the different PR - all is good.

@paulbalandan paulbalandan merged commit 453ec56 into codeigniter4:develop Mar 18, 2025
47 checks passed
@paulbalandan paulbalandan deleted the phpstan-tests branch March 18, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants