Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Issue on Windows #447

Closed
HeIp opened this issue Aug 17, 2020 · 15 comments
Closed

Tutorial Issue on Windows #447

HeIp opened this issue Aug 17, 2020 · 15 comments
Assignees
Labels
bug Something isn't working

Comments

@HeIp
Copy link
Contributor

HeIp commented Aug 17, 2020

Steps to reproduce the behavior:

  1. Started Learn NPM package json
  2. Click on run after adding author property to package.json
  3. See error

Expected behavior
Expected to move on to the next section

Screenshots
image
Started trying out the plugin but got stuck.

Desktop (please complete the following information):

  • Platform: Windows
  • OS: Windows 10
  • Version Version 10.0.19041 Build 19041

VSCode (please complete the following information):

  • Version 1.48.0

Node (please complete the following information):

  • Version 12.8.1

Git (please complete the following information):

  • Version 2.27.0.windows.1
@HeIp HeIp added the bug Something isn't working label Aug 17, 2020
@ShMcK
Copy link
Member

ShMcK commented Aug 17, 2020

I'm guessing the test runner didn't install correctly. Let's find out why.

If you don't see a /coderoad/package-lock.json that's a good indicator.

In the terminal, can you type

cd coderoad
npm install

Let me know if any errors come up.

To open a terminal in vscode, press ctrl + backtick (^`)

@HeIp
Copy link
Contributor Author

HeIp commented Aug 17, 2020

Did as instructed, failed again.
here's a picture of the contents:
image

@ShMcK
Copy link
Member

ShMcK commented Aug 17, 2020

Can you try closing the CodeRoad window, then re-launching it?

Choose the continue option.

@HeIp
Copy link
Contributor Author

HeIp commented Aug 17, 2020

Test Runner still failed after doing so

@ShMcK
Copy link
Member

ShMcK commented Aug 17, 2020

Definitely shows I'll have to add some logging to debug issues like these in the future.

What happens if you run npm test in the command line?

@HeIp
Copy link
Contributor Author

HeIp commented Aug 17, 2020

mocha

package.json
√ should have a valid "author" key

1 passing (8ms)

@ShMcK
Copy link
Member

ShMcK commented Aug 17, 2020

Maybe just one more test.

Can you go in the coderoad directory (cd coderoad), then run:

./node_modules/.bin/mocha

If that works, try running:

./node_modules/.bin/mocha --reporter=mocha-tap-reporter

@HeIp
Copy link
Contributor Author

HeIp commented Aug 17, 2020

As a note I would like to clarify that I ran the previous commands inside the coderoad folder.
running npm test outside the coderoad folder I got the following:

echo 'Error: no test specified'

'Error: no test specified'

and what you ask for now:
./node_modules/.bin/mocha
'.' is not recognized as an internal or external command,
operable program or batch file.

@ShMcK
Copy link
Member

ShMcK commented Aug 17, 2020

Looks like the tutorial won't run on windows because of the path to the test runner executable. Only Linux/Mac for now.

I'll try to put in a fix later today and re-publish the tutorials.

Thank you greatly for your help @HeIp !

@HeIp
Copy link
Contributor Author

HeIp commented Aug 17, 2020

No problem, @ Me when you do so

@ShMcK ShMcK changed the title Learn NPM package json bug in advancing Tutorial Issue on Windows Aug 17, 2020
@ShMcK
Copy link
Member

ShMcK commented Aug 17, 2020

Could you try running the tutorial again from a different workspace? I've fixed the executable paths.

@HeIp
Copy link
Contributor Author

HeIp commented Aug 18, 2020

No change
Pic of terminal command history :
image

@ShMcK
Copy link
Member

ShMcK commented Aug 18, 2020

I tried testing on a Windows VM, but was pretty slow and frustrating.

I've ordered a Windows computer that arrives tomorrow and hope to debug and better test releases.

@HeIp
Copy link
Contributor Author

HeIp commented Aug 18, 2020

Oof

@ShMcK
Copy link
Member

ShMcK commented Aug 19, 2020

My shiny new $100 Windows computer arrived. It's about the size of two credit cards, didn't expect that.

Good news though: I've found a few issues and will put in a fix.

I'll close this ticket in favor of the more descriptive #451. The issue seems to match up with your description exactly.

Until then, I've removed the "Windows" from supported OS's in the README. Coming soon!

@ShMcK ShMcK closed this as completed Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants