Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having git configured to gpgsign commits is interfering with tutorial #520

Closed
moT01 opened this issue Nov 3, 2021 · 2 comments · Fixed by #521
Closed

Having git configured to gpgsign commits is interfering with tutorial #520

moT01 opened this issue Nov 3, 2021 · 2 comments · Fixed by #521
Assignees
Labels
bug Something isn't working

Comments

@moT01
Copy link
Contributor

moT01 commented Nov 3, 2021

From one of our users:

"After starting container, CodeRoad plugin, and starting tutorial, it seemed to not run setup at all (the pop-ups with run commands weren't displayed). After updating rdb-alpha with freeCodeCamp/rdb-alpha#7 setup seems to run, however running tests still fails. When gpgsign option in git config is commented out, everything works fine."

I haven't attempted to replicate this. I will give it a try and post what I find - maybe it's something with the container we are using. I don't think so though. Assuming it's not, CodeRoad could maybe use a check for that - similar to, or along with, the check for a git username and email:
Screen Shot 2021-11-03 at 9 13 45 AM

Or perhaps a way around the signed commits. Not sure exactly what is breaking, maybe there's a simpler way around it. It's not a big issue, just thought I would point it out.

@moT01 moT01 added the bug Something isn't working label Nov 3, 2021
@ShMcK
Copy link
Member

ShMcK commented Nov 6, 2021

I can reproduce it by adding commit.gpgsign = true to my .gitconfig. I'll look into the cause/solution.

@ShMcK
Copy link
Member

ShMcK commented Nov 6, 2021

The PR in #521 may not resolve the issue, but it will display to the user a clear message of why it failed.

@ShMcK ShMcK closed this as completed in #521 Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants