Skip to content

allow for separate coderoad directory #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2020
Merged

Conversation

ShMcK
Copy link
Member

@ShMcK ShMcK commented Apr 17, 2020

closes #273.
closes #187.

Allows for CodeRoad test runner to be built in a separate directory.

  • This is a breaking change, so should require first validating the version of CodeRoad schema with the version of the extension first.

Signed-off-by: shmck shawn.j.mckay@gmail.com

@ShMcK ShMcK added this to the Stable Release milestone Apr 17, 2020
@ShMcK ShMcK force-pushed the feature/coderoad-directory branch from 26bdfcc to a335f07 Compare April 17, 2020 01:00
ShMcK added 2 commits April 16, 2020 20:28
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
@ShMcK ShMcK force-pushed the feature/coderoad-directory branch from a335f07 to eaf27ff Compare April 17, 2020 03:34
Signed-off-by: shmck <shawn.j.mckay@gmail.com>
@ShMcK
Copy link
Member Author

ShMcK commented Apr 17, 2020

One remaining issue.

  • The setup commands in the coderoad directory don't seem to work correctly.
    Eg. npm install generates a coderoad/package-lock.json, but no coderoad/node_modules.

If I run the same commands manually, they work. Really not sure why.

@ShMcK
Copy link
Member Author

ShMcK commented Apr 18, 2020

Resovled - issue was related to my local NODE_ENV=production, and the test dependencies living in devDependencies that don't get called in npm install when production.

Signed-off-by: shmck <shawn.j.mckay@gmail.com>
@ShMcK ShMcK merged commit d875e4c into master Apr 18, 2020
@ShMcK ShMcK deleted the feature/coderoad-directory branch April 18, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run coderoad from separate folder Ensure test runner is installed before commands run
1 participant