Skip to content

WIP - Split state machines #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

WIP - Split state machines #83

wants to merge 11 commits into from

Conversation

ShMcK
Copy link
Member

@ShMcK ShMcK commented Jan 25, 2020

Splits the state machines into two machines with their own actions. Should simplify the two parts of the app and make it easier to develop each in separation.

Previous Single Machine
image

New Select Tutorial Machine
image

New Play Tutorial Machine
image

@ShMcK ShMcK requested review from argemiront and removed request for argemiront January 25, 2020 22:32
@ShMcK ShMcK changed the title Split state machines WIP - Split state machines Jan 25, 2020
@ShMcK
Copy link
Member Author

ShMcK commented Jan 25, 2020

Changes:

Move Summary & Configure logic into setup:

image

image

@ShMcK ShMcK force-pushed the feature/refactor-states branch from 7a05f4b to e3a7753 Compare January 25, 2020 23:13
@ShMcK
Copy link
Member Author

ShMcK commented Jan 27, 2020

Close PR as can't complete without an ability to expose invoked machines in XState. Feature is expected in XState v5.

@ShMcK ShMcK closed this Jan 27, 2020
@ShMcK ShMcK deleted the feature/refactor-states branch April 3, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant