-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(native): Native gateway - support check_auth, context_to_api_scopes #9377
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9377 +/- ##
==========================================
- Coverage 83.72% 83.72% -0.01%
==========================================
Files 229 229
Lines 82574 82580 +6
==========================================
Hits 69138 69138
- Misses 13436 13442 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dc28ae8
to
b7531f2
Compare
4a97c6a
to
87882e8
Compare
@@ -15,7 +15,7 @@ | |||
"typings": "dist/src/index.d.ts", | |||
"scripts": { | |||
"test": "npm run unit", | |||
"unit": "jest --coverage dist/test", | |||
"unit": "CUBE_JS_NATIVE_API_GATEWAY_INTERNAL=true jest --coverage --forceExit dist/test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation:
--force exit
is a workaround for a leaked handler somewhere in the rust part. I figure out one with setupLogger,
and most probably, another part is registerInterface.
It's an old known bug, and I don't plan to fix it in the scope of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thnx for the explanation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM!
@@ -15,7 +15,7 @@ | |||
"typings": "dist/src/index.d.ts", | |||
"scripts": { | |||
"test": "npm run unit", | |||
"unit": "jest --coverage dist/test", | |||
"unit": "CUBE_JS_NATIVE_API_GATEWAY_INTERNAL=true jest --coverage --forceExit dist/test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thnx for the explanation!
No description provided.