Skip to content

Commit 587ed96

Browse files
committed
Fix shellcheck linter warnings in build scripts.
1 parent cbc127c commit 587ed96

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

build/run-tests.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
set -e
33

44
SCRIPT=$(readlink -f "$0")
5-
BUILD_DIR=$(dirname $SCRIPT)
6-
PROJECT_DIR=$(dirname $BUILD_DIR)
5+
BUILD_DIR=$(dirname "$SCRIPT")
6+
PROJECT_DIR=$(dirname "$BUILD_DIR")
77

8-
$PROJECT_DIR/build/start-android-emulator.sh &
8+
"$PROJECT_DIR/build/start-android-emulator.sh" &
99
EMULATOR_STARTER_PID=$!
1010

11-
. $PROJECT_DIR/build/tns.sh
11+
. "$PROJECT_DIR/build/tns.sh"
1212

1313
activate_node_env
1414

@@ -18,7 +18,7 @@ npm install
1818
rm -rf platforms/android
1919
tns platform add android
2020

21-
wait $EMULATOR_STARTER_PID
21+
wait "$EMULATOR_STARTER_PID"
2222
tns test android | tee test-output.txt
2323

2424
if grep -q -E 'Executed[[:space:]][[:digit:]]+.*FAILED' test-output.txt ; then

build/tns.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export NODE_VER="v5.5.0"
77

88
install_nvm() {
99
if [ ! -d "$NVM_DIR" ] ; then
10-
git clone --depth=1 $NVM_REPO $NVM_DIR
10+
git clone --depth=1 $NVM_REPO "$NVM_DIR"
1111
else
1212
echo "NVM detected at $NVM_DIR"
1313
fi
@@ -18,7 +18,7 @@ activate_nvm() {
1818
}
1919

2020
installed_under_nvm() {
21-
which $1 | grep -q "$NVM_DIR"
21+
which "$1" | grep -q "$NVM_DIR"
2222
}
2323

2424
install_node() {

0 commit comments

Comments
 (0)