Skip to content

Commit aa84044

Browse files
committed
Send 'isIncomplete' flag back to editor for emmet completes
Fixes microsoft#41 Uses the new metadata property to send this data back for emmet completions
1 parent dce60e9 commit aa84044

File tree

6 files changed

+130
-117
lines changed

6 files changed

+130
-117
lines changed

e2e/package-lock.json

+56-56
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"author": "",
1515
"license": "ISC",
1616
"dependencies": {
17-
"typescript": "2.9.2",
17+
"typescript": "^3.2.0-dev.20181107",
1818
"typescript-styled-plugin": "file:./.."
1919
}
2020
}

e2e/tests/emmetCompletions.js

+10
Original file line numberDiff line numberDiff line change
@@ -142,4 +142,14 @@ describe('Emmet Completions', () => {
142142
const completionsResponse = getFirstResponseOfType('completions', server);
143143
assert.isTrue(completionsResponse.body.some(item => item.name === '#121212'));
144144
});
145+
146+
it('should mark emmet completions as isIncomplete', async () => {
147+
const { server, mockFileName } = createMockFileForServer('const q = css`m10-20`');
148+
server.sendCommand('completions', { file: mockFileName, offset: 21, line: 1 });
149+
150+
await server.close();
151+
const completionsResponse = getFirstResponseOfType('completions', server);
152+
assert.isTrue(completionsResponse.body.some(item => item.name === 'margin: 10px 20px;'));
153+
assert.isTrue(completionsResponse.metadata.isIncomplete);
154+
});
145155
});

0 commit comments

Comments
 (0)