TYP: Type annotations overhaul, episode 2 #288
Conversation
| from typing import TYPE_CHECKING | ||
|
|
||
| def get_xp(xp): | ||
| __all__ = ["get_xp"] | ||
|
|
||
| if TYPE_CHECKING: | ||
| from collections.abc import Callable | ||
| from types import ModuleType | ||
| from typing import TypeVar |
There was a problem hiding this comment.
I much prefer avoiding if TYPE_CHECKING blocks when possible, and use them only when necessary (circular imports and runtime support for obsolete versions of python).
The performance implications of importing from typing at runtime are absolutely negligible.
| _T = TypeVar("_T") | ||
|
|
||
|
|
||
| def get_xp(xp: "ModuleType") -> "Callable[[Callable[..., _T]], Callable[..., _T]]": |
There was a problem hiding this comment.
please use bare annotations.
Where it would break things, because you either have a circular dependency or a if TYPE_CHECKING block, please add from __future__ import annotations to the top of the module.
| from ._typing import Array, Device, DType, Namespace | ||
|
|
||
| if TYPE_CHECKING: | ||
| from typing_extensions import TypeIs |
There was a problem hiding this comment.
| from typing_extensions import TypeIs | |
| # TODO: import from typing (requires Python >=3.13) | |
| from typing_extensions import TypeIs |
these comments make upgrading minimum python version so much easier.
There was a problem hiding this comment.
Yea makes sense.
pyupgrade (part of ruff) can also help a lot with that, fyi
|
I'm not really sure what's causing these test failures here 🤔 |
They're in main too |
This is a WIP in progress, but feel free to say whatever you feel like saying about the stuff I've already touched at this point.
_internalcommon/*numpy__init___aliases_info_typingfftlinalgtorch.*dask.array.*Because
cupyhas nopy.typed, and is too dynamic for pyright to analyse, it's pretty much impossible to annotatecupy.*at the moment.