enhanc: Create cm on cluster action oss #6607
Open
+11,789
−412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.mod # go.sum # vendor/github.com/devtron-labs/common-lib/utils/k8s/K8sUtil.go # vendor/modules.txt
prakash100198
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
# Conflicts: # go.mod # go.sum # vendor/modules.txt
nishant-d
requested changes
May 27, 2025
| if err != nil { | ||
| impl.logger.Errorw("error in creating secret for informers", "secretName", secretName, "err", err) | ||
| cmData, labels := helper.CreateClusterModifyEventData(bean.Id, informerBean.ClusterActionAdd) | ||
| if err = impl.upsertClusterConfigMap(bean, cmData, labels); err != nil { |
There was a problem hiding this comment.
always update label inside upsert
Ash-exp
previously approved these changes
May 27, 2025
… images (#6512) * updated golang version to 1.23 * updated go sample dockerfile * modified versions to java-21 LTS * modified versions to node v22.14.0 LTS * modified versions to node v22.14.0 LTS * updated base images versions * update Dockerfile for non-root user and update latest stable * update dockerfile and nginx.conf * added dockerfile for react * refactor * refactor * refactor * refactor * resolved all review points * wip --------- Co-authored-by: pawan-59 <pawan@devtron.ai> Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local>
chore: Gpu workload chart
* Added cronjob-chart_1-6-0 chart * modified esosecrets * updated app-values.yaml * Updated the conditons for timeZone * Updated the conditons for timeZone * added esosecret test case * updated the schema.json added timeZone * incorporated the CONFIG_HASH and SECRET_HASH changes * added cases for containerExtraSpecs and podExtraSpecs * added down for migration * Create 33503701_cronjob_job_1-6-0.up.sql * Removed chart_ref_default line * Updated up migration * Rename 33503701_cronjob_job_1-6-0.down.sql to 33603700_cronjob_job_1-6-0.down.sql * Rename 33503701_cronjob_job_1-6-0.up.sql to 33603700_cronjob_job_1-6-0.up.sql
# Conflicts: # env_gen.json # go.mod # go.sum # pkg/delete/DeleteService.go # vendor/modules.txt
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9257608 | Triggered | Base64 AWS keys | a61bf2f | scripts/devtron-reference-helm-charts/gpu-workload-4-21-0/test-values.json | View secret |
| 2763127 | Triggered | Generic High Entropy Secret | 6e196cb | scripts/devtron-reference-helm-charts/cronjob-chart_1-6-0/secrets-test-values.yaml | View secret |
| 141558 | Triggered | Generic High Entropy Secret | a61bf2f | scripts/devtron-reference-helm-charts/gpu-workload-4-21-0/env-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
# Conflicts: # go.mod # go.sum # vendor/modules.txt
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Ash-exp
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Checklist:
Does this PR introduce a user-facing change?