feat: supply eclipse formatter settings as XML content #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasbjerre
commented
Dec 11, 2024
| @@ -136,22 +169,10 @@ void invalidPropertyFiles() throws IOException { | |||
| } | |||
|
|
|||
| @Test | |||
| void invalidPropertyFiles_content_properties() throws IOException { | |||
There was a problem hiding this comment.
Removed this test, the list from invalidPropertiesResources() was empty because there are no such invalid property files.
|
I think the error here is just infrastructure problem. "It works on my machine". |
|
@tomasbjerre Could this be updated to resolve conflicts so @nedtwigg could review it? |
|
Conflicts resolved now. I dont know what failing check is about, it does work locally for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2343. This PR enables a user to add Eclipse preferences in XML format, as content, without having it in a file.