Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Default Language #57

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

DWDBE
Copy link
Contributor

@DWDBE DWDBE commented Mar 17, 2025

No description provided.

@DWDBE DWDBE requested a review from frederik5480 as a code owner March 17, 2025 11:32
@DWDBE DWDBE requested review from MatthiasSort and removed request for frederik5480 March 17, 2025 11:32
frederik5480
frederik5480 previously approved these changes Mar 20, 2025
@@ -470,6 +447,7 @@ public override bool RunJob(Job job)
bool deactivateMissingProducts = false;
try
{
string defaultLanguage = Ecommerce.Services.Languages.GetDefaultLanguageId();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to be careful with this - with this solution, if no languageid columnmapping exists, we create a hidden one for the job. I don't believe this is the intended behaviour, we'll need to discuss this with Rasmus.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the default languageId is needed in the mappings, so you can not import products without LanguageId, etc so for ages it worked like that, once there was no language id in the mapping it was auto added, a lot of existing jobs will fail if we remove that support, also the jobs @MatthiasSort is using for the BluePrints BC import may fail.
Usually ERP systems don't care what is the default language id in DW, so it is super incovenient to adjust manually the jobs

@frederik5480 frederik5480 self-requested a review March 20, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants