-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Default Language #57
base: main
Are you sure you want to change the base?
Conversation
@@ -470,6 +447,7 @@ public override bool RunJob(Job job) | |||
bool deactivateMissingProducts = false; | |||
try | |||
{ | |||
string defaultLanguage = Ecommerce.Services.Languages.GetDefaultLanguageId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to be careful with this - with this solution, if no languageid columnmapping exists, we create a hidden one for the job. I don't believe this is the intended behaviour, we'll need to discuss this with Rasmus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the default languageId is needed in the mappings, so you can not import products without LanguageId, etc so for ages it worked like that, once there was no language id in the mapping it was auto added, a lot of existing jobs will fail if we remove that support, also the jobs @MatthiasSort is using for the BluePrints BC import may fail.
Usually ERP systems don't care what is the default language id in DW, so it is super incovenient to adjust manually the jobs
No description provided.