Skip to content

Fix spelling of "supress" #21934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Fix spelling of "supress" #21934

merged 1 commit into from
Jul 9, 2025

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented May 23, 2025

This commit fixes the misspelled function name
supressInliningRecognizedInitialCallee().

@knn-k knn-k added the comp:jit label May 23, 2025
@knn-k
Copy link
Contributor Author

knn-k commented May 23, 2025

This commit requires a coordinated merge with eclipse-omr/omr#7764.

@knn-k
Copy link
Contributor Author

knn-k commented May 23, 2025

Jenkins build amac jdk11 depends eclipse-omr/omr#7764

@knn-k
Copy link
Contributor Author

knn-k commented May 23, 2025

Jenkins compile amac jdk11depends eclipse-omr/omr#7764

@knn-k
Copy link
Contributor Author

knn-k commented May 23, 2025

Jenkins compile amac jdk11 depends eclipse-omr/omr#7764

@knn-k knn-k marked this pull request as ready for review May 23, 2025 05:06
@knn-k knn-k mentioned this pull request May 23, 2025
Merged
keithc-ca
keithc-ca reviewed May 23, 2025
View reviewed changes
@knn-k
Fix spelling of "supress"
9344481 
This commit fixes the misspelled function name
supressInliningRecognizedInitialCallee().

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented May 26, 2025

Jenkins compile amac jdk11 depends eclipse-omr/omr#7764

@knn-k knn-k added the depends:omr Pull request is dependent on a corresponding change in OMR label Jun 5, 2025
@hzongaro hzongaro self-assigned this Jul 4, 2025
hzongaro
hzongaro approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

hzongaro commented Jul 4, 2025

The change looks good, but we'll have to wait until the latest OMR changes have been promoted to openj9-omr before performing the coordinated merge.

@hzongaro
Copy link
Member

hzongaro commented Jul 5, 2025

I know this looks like overkill, but it's what's required for a coordinated merge. . . .

Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 6, 2025

Some testing looks like it was aborted prematurely. Rerunning those. . . .

Jenkins test sanity.openjdk xmaxc,plinux,win jdk11 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 6, 2025

Jenkins test sanity.openjdk xmac jdk11 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 6, 2025

Jenkins test sanity.functional,sanity.openjdk win jdk17 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 6, 2025

Jenkins test sanity.functional,sanity.openjdk aix jdk21 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 6, 2025

Jenkins test sanity.openjdk win jdk21 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 6, 2025

Jenkins test sanity.openjdk win32 jdk8 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 7, 2025

Jenkins test sanity.functional,sanity.openjdk win jdk11,jdk17 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 7, 2025

Jenkins test sanity.functional aix jdk11 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 7, 2025

Jenkins test sanity.openjdk plinux jdk11 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 7, 2025

I will hold off rerunning the zLinux testing, as I’m guessing that those failures are related to the fact that eclipse-omr/omr#7721 hasn’t been promoted yet to the openj9 branch of openj9-omr.

@hzongaro
Copy link
Member

hzongaro commented Jul 8, 2025

Rerunning zlinux testing

Jenkins test sanity.functional,sanity.openjdk zlinux jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7764

@hzongaro
Copy link
Member

hzongaro commented Jul 9, 2025

Failures running sanity.functional testing for jdk11 aix, jdk11 Windows and jdk 17 Windows were all in cmdLineTester_jfrEvents_0. That appears to be known issue #21316.

@hzongaro hzongaro merged commit b1bd9ac into eclipse-openj9:master Jul 9, 2025
96 of 99 checks passed
@knn-k knn-k deleted the fixSupress branch July 9, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca left review comments

@hzongaro hzongaro hzongaro approved these changes

Assignees

@hzongaro hzongaro

Labels
comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knn-k @hzongaro @keithc-ca