Remove TR_X87_Mask guarded code #22103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X87 registers are no longer allocated. Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
|
Internal testing here |
|
@BradleyWood : please review |
BradleyWood
reviewed
Jun 17, 2025
| @@ -71,14 +71,11 @@ TR::Snippet *TR::X86MemImmSnippetInstruction::getSnippetForGC() | |||
| void TR::X86MemImmSnippetInstruction::assignRegisters(TR_RegisterKinds kindsToBeAssigned) | |||
| { | |||
| TR::X86MemImmInstruction::assignRegisters(kindsToBeAssigned); | |||
| if (kindsToBeAssigned & (TR_X87_Mask | TR_FPR_Mask)) | |||
| if (kindsToBeAssigned & TR_FPR_Mask) | |||
There was a problem hiding this comment.
Can you confirm if TR_X87_Mask is ever set? If its not, then this probably doesn't depend on eclipse-omr/omr#7799 and we can avoid a coordinated merge situation.
There was a problem hiding this comment.
It would avoid a coordinated merge, but I think this pull request would need to be merged before eclipse-omr/omr#7799 could be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X87 registers are no longer allocated.
Requires coordinated merge with eclipse-omr/omr#7799