Resizable columns for Assets Table #13327

somebody1234 · 2025-06-19T08:36:31Z

Pull Request Description

Close https://github.com/enso-org/cloud-v2/issues/1468
- Add column resizing for table
- Persist column sizes across restarts

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

~~The documentation has been updated, if necessary.~~
~~Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.~~
All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
~~Unit tests have been written where possible.~~
If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
or the Snowflake database integration, a run of the Extra Tests has been scheduled.
- ~~If applicable, it is suggested to paste a link to a successful run of the Extra Tests.~~

github-actions · 2025-06-19T08:36:45Z

✨ GUI Checks Results

Summary

🧹 Prettier: ✅ Passed
🧰 GUI Checks: ❌ Failed
📚 Storybook: ✅ Deployed

⚠️ Action Required: Please review the failed checks and fix them before merging.

See individual check results for more details.

ℹ️ Chromatic Tests Skipped

Chromatic visual regression tests were skipped for this PR.

To run the tests and deploy Storybook, add the CI: Run Chromatic label to this PR.

Note: We skip tests by default to optimize CI costs. Only run them when your UI changes are ready for review.

👮 Lint GUI Results

Check Results

🧠 Typecheck: ✅ Passed
🧹 Lint: ✅ Passed
🧪 Unit Tests: ✅ Passed

🎭 Playwright Test Results

Summary

⏳ Duration: 11m 20s
✅ Passed: 354 tests
🔴 Failed: 12 tests
⚠️ Flaky: 1 tests

📥 Download Detailed Report

⚠️ Action Required: Please review the failed tests and fix them before merging.

PabloBuchu · 2025-06-19T13:10:16Z

I mini scroll bars on every table header

Most right column has weird fixed width. This creates empty space between the table and right side

I can resize left column to full width moving modified_at and labels offscreen. Then the horizonatal scroll bar appers. Ideally we want min width for each column and not allow users to move table offscreen

This reverts commit 38b9722.

somebody1234 · 2025-06-19T14:02:48Z

mini scroll bars on every table header

those are the column resizers (as you may have figured out already), but i would appreciate suggestions on how to make them look less like scrollbars

most right column has weird fixed width. This creates empty space between the table and right side

tried to fix it but it breaks resizing (causing the handle to jump when resizing starts). one question: must it take up all available space?

can make table wider than screen

intentional - this is fine with the current columns but what do we do if there are more columns? (4/5/6 columns)
see example screenshot:

somebody1234 · 2025-06-19T14:03:36Z

although it's possible that UX may be improved, i'm not completely sure that 100% width is the way to go

farmaazon

The changes in package.jsons are not the cleanest, and I'm not sure if they will work good with bazel.

farmaazon · 2025-06-23T08:03:07Z

app/common/tsconfig.json

@@ -4,7 +4,6 @@
    "lib": ["DOM", "es2023"],
    "allowJs": true,
    "checkJs": true,
-    "skipLibCheck": false,


Why this change? And do you know why did we have this?

do you know why did we have this?

no tbh

Why this change

was trying to fix errors due to the updates. can try reverting.

nvm, i dont think this should be an issue, it's been there since the start but there shouldn't be any reason to explicitly override it

farmaazon · 2025-06-23T08:08:24Z

app/gui/src/dashboard/components/aria/index.ts

+// @ts-expect-error All conflicting exports are types
 export type * from '@react-types/shared'
+// @ts-expect-error All conflicting exports are types
 export * from 'react-aria'
-// @ts-expect-error The conflicting exports are props types ONLY
+// @ts-expect-error All conflicting exports are props types


So why conflicting types are ok here? Are we sure they're same types?

Instead of TS exceptions, I'd prefer just listing exports manually.

Are we sure they're same types?

yes, they are packages from the same monorepo. we can export types manually but there are a lot of re-exports. i can specifically export just the exports we need though.

farmaazon · 2025-06-23T08:20:16Z

app/gui/src/dashboard/layouts/AssetsTable.tsx

+        if (widths === prevWidths) {
+          return
+        }


As setWidths always creates a new object, I think this if isn't necessary?

technically yes, but this is to protect against any possible future expansion of the store - if other keys are changed, widths stays the same

farmaazon · 2025-06-23T08:30:51Z

package.json

+  "//": [
+    "To completely ignore deep dependencies, see .pnpmfile.cjs",
+    "the following are overridden due to breaking changes in type definitions:",
+    "@react-stately/*",
+    "@react-aria/*",
+    "@internationalized/*"
+  ],


Wait, so we are bumping versions but keeping the old type definitions? Why are we doing this?

we are not, we are bumping versions but to the version right before upstream broke all type definitions at the end of last month - the new versions are from right before that commit

somebody1234 · 2025-06-23T08:36:58Z

@farmaazon can you elaborate on the changes in the package.jsons?

… again

somebody1234 added 8 commits June 19, 2025 01:04

[dashboard/AssetsTable] WIP: Column resizing

456d6bc

[dashboard] Upgrade react-spectrum

ec4318d

[dashboard] Use aria PortalProvider

755aeb5

[dashboard] Fix type errors

0f65329

[dashboard] WIP: Fix Assets Table

3578b86

[dashboard] Fix Assets Table column resizing

d6d7dd4

[dashboard/AssetsTable] Disable drag-to-select when resizing columns

e0b2ded

[dashboard/AssetsTable] Style column resizer; add tooltip

ea42383

somebody1234 requested review from Frizi and farmaazon as code owners June 19, 2025 08:36

somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 19, 2025

somebody1234 requested review from vitvakatu, kazcw and AdRiley as code owners June 19, 2025 08:36

somebody1234 added the x-new-feature Type: new feature request label Jun 19, 2025

somebody1234 requested review from PabloBuchu and indiv0 as code owners June 19, 2025 08:36

somebody1234 added the g-dashboard label Jun 19, 2025

somebody1234 changed the title ~~Wip/sb/resizable table~~ Resizable columns for Assets Table Jun 19, 2025

somebody1234 added 3 commits June 19, 2025 23:53

Merge branch 'develop' into wip/sb/resizable-table

94b1ad5

[dashboard/AssetsTable] Make last column fill up rest of space

38b9722

Revert "[dashboard/AssetsTable] Make last column fill up rest of space"

1741186

This reverts commit 38b9722.

somebody1234 added 4 commits June 20, 2025 00:05

Fix invisible column headings

fa8d921

Fix Bazel lockfile

868bcf2

[dashboard/ColumnResizer] Only show on hover

ca0ed65

[dashboard/Drive] Fix sidebar width

69cc5d7

somebody1234 added 2 commits June 20, 2025 22:10

[dashboard/AssetsTable] Fix editing name in row

30d11b0

[dashboard] Fix some integration tests

fd43651

farmaazon reviewed Jun 23, 2025

View reviewed changes

somebody1234 added 2 commits June 23, 2025 23:19

[dashboard] Remove @ts-expect-errors in components/aria

9a01206

Fix TS errors (remove `"customConditions": ["source"])

6267bf8

somebody1234 requested a review from farmaazon June 23, 2025 14:59

somebody1234 added 3 commits June 24, 2025 01:19

[dashboard/AssetsTable] Make last column occupy the rest of the width…

0fc51fe

… again

Revert MODULE.bazel.lock

dc39fff

[dashboard] Restore source condition as enso-source

a52abdb

PabloBuchu approved these changes Jun 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Resizable columns for Assets Table #13327

Resizable columns for Assets Table #13327

somebody1234 commented Jun 19, 2025

Uh oh!

github-actions bot commented Jun 19, 2025 •

edited

Loading

Uh oh!

PabloBuchu commented Jun 19, 2025

Uh oh!

somebody1234 commented Jun 19, 2025

Uh oh!

somebody1234 commented Jun 19, 2025

Uh oh!

farmaazon left a comment

Uh oh!

farmaazon Jun 23, 2025

Uh oh!

somebody1234 Jun 23, 2025

Uh oh!

somebody1234 Jun 23, 2025

Uh oh!

farmaazon Jun 23, 2025

Uh oh!

somebody1234 Jun 23, 2025

Uh oh!

farmaazon Jun 23, 2025

Uh oh!

somebody1234 Jun 23, 2025

Uh oh!

farmaazon Jun 23, 2025

Uh oh!

somebody1234 Jun 23, 2025

Uh oh!

somebody1234 commented Jun 23, 2025

Uh oh!

Uh oh!

Resizable columns for Assets Table #13327

Are you sure you want to change the base?

Resizable columns for Assets Table #13327

Conversation

somebody1234 commented Jun 19, 2025

Pull Request Description

Important Notes

Checklist

Uh oh!

github-actions bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ GUI Checks Results

Summary

ℹ️ Chromatic Tests Skipped

👮 Lint GUI Results

Check Results

🎭 Playwright Test Results

Summary

Uh oh!

PabloBuchu commented Jun 19, 2025

Uh oh!

somebody1234 commented Jun 19, 2025

Uh oh!

somebody1234 commented Jun 19, 2025

Uh oh!

farmaazon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

somebody1234 commented Jun 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 19, 2025 •

edited

Loading