feat(zigbee): Add PM2.5 endpoint support #11205
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Test Results 76 files 76 suites 12m 43s ⏱️ Results for commit 35b9d63. ♻️ This comment has been updated with latest results. |
me-no-dev
added
Status: Pending Merge
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for a Zigbee PM2.5 sensor by introducing a new endpoint class with its associated example and updating the Zigbee endpoint include order.
- Introduces the ZigbeePM25Sensor class and its configuration in both header and source files.
- Updates the main Zigbee header to include the new sensor endpoint and reorganizes related endpoints.
- Provides an Arduino example and README for the new PM2.5 sensor.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libraries/Zigbee/src/ep/ZigbeePM25Sensor.h | New endpoint header defining the PM2.5 sensor configuration. |
| libraries/Zigbee/src/ep/ZigbeePM25Sensor.cpp | Implementation of the PM2.5 sensor endpoint and its methods. |
| libraries/Zigbee/src/Zigbee.h | Reordered and added include for the new PM2.5 sensor endpoint. |
| libraries/Zigbee/examples/Zigbee_PM25_Sensor/Zigbee_PM25_Sensor.ino | Example demonstrating usage of the PM2.5 sensor endpoint. |
| libraries/Zigbee/examples/Zigbee_PM25_Sensor/README.md | Documentation for the new PM2.5 sensor example. |
Files not reviewed (2)
- CMakeLists.txt: Language not supported
- libraries/Zigbee/examples/Zigbee_PM25_Sensor/ci.json: Language not supported
Comments suppressed due to low confidence (1)
libraries/Zigbee/examples/Zigbee_PM25_Sensor/README.md:12
- The heading 'Pressure + Flow Sensor Functions' does not match the focus on PM2.5 sensing; consider updating it to reflect the PM2.5 sensor functionality for clarity.
## Pressure + Flow Sensor Functions
| // reporting_info.u.send_info.delta.u16 = (uint16_t)(delta * 100); // Convert delta to ZCL uint16_t | ||
| reporting_info.dst.profile_id = ESP_ZB_AF_HA_PROFILE_ID; | ||
| reporting_info.manuf_code = ESP_ZB_ZCL_ATTR_NON_MANUFACTURER_SPECIFIC; | ||
| float delta_f = delta; | ||
| memcpy(&reporting_info.u.send_info.delta.s32, &delta_f, sizeof(float)); | ||
|
|
There was a problem hiding this comment.
Using memcpy to assign a float value into an integer field (s32) may lead to unintended behavior; consider applying an explicit conversion or scaling as suggested by the commented-out code to properly format the delta value.
| // reporting_info.u.send_info.delta.u16 = (uint16_t)(delta * 100); // Convert delta to ZCL uint16_t | |
| reporting_info.dst.profile_id = ESP_ZB_AF_HA_PROFILE_ID; | |
| reporting_info.manuf_code = ESP_ZB_ZCL_ATTR_NON_MANUFACTURER_SPECIFIC; | |
| float delta_f = delta; | |
| memcpy(&reporting_info.u.send_info.delta.s32, &delta_f, sizeof(float)); | |
| reporting_info.u.send_info.delta.u16 = (uint16_t)(delta * 100); // Convert delta to ZCL uint16_t | |
| reporting_info.dst.profile_id = ESP_ZB_AF_HA_PROFILE_ID; | |
| reporting_info.manuf_code = ESP_ZB_ZCL_ATTR_NON_MANUFACTURER_SPECIFIC; | |
| // float delta_f = delta; | |
| // memcpy(&reporting_info.u.send_info.delta.s32, &delta_f, sizeof(float)); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Description of Change
This pull request introduces a new Zigbee PM2.5 sensor example for the Zigbee Library.
Tests scenarios
Tested using C6 and HomeAssistant ZHA (in ZHA the PM2.5 does not support decimals, so the data from sensor are rounded. Will be fixed soon on ZHA side).
Related links
Related #11036