fix: incorrect link for opting out of deep imports deprecation warning #4648
Conversation
|
Hi @floydkim! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| @@ -30,7 +30,7 @@ Moreover, the Legacy Architecture of React Native is now officially frozen, and | |||
|
|
|||
| In this release, we are making moves to improve and stabilize React Native's public JavaScript API. The first step towards this is better scoping of which of our APIs are importable by apps and frameworks. In line with this, we are formally deprecating deep imports from React Native ([see RFC](https://github.com/react-native-community/discussions-and-proposals/pull/894)), and are introducing warnings via ESLint and the JS console. | |||
|
|
|||
| These warnings are scoped to imports from within your project's source code, and can be [opted out from](/docs/strict-typescript-api). However, please bear in mind that we aim to remove deep imports from React Native's API in a future release, and these should instead be updated to the root import. | |||
| These warnings are scoped to imports from within your project's source code, and can be [opted out from](https://reactnative.dev/blog/2025/06/12/moving-towards-a-stable-javascript-api#deprecating-deep-imports-from-react-native). However, please bear in mind that we aim to remove deep imports from React Native's API in a future release, and these should instead be updated to the root import. | |||
There was a problem hiding this comment.
cc @huntie as I believe the original link is actually correct
|
Although a bit late, I’ve discovered that the same broken link issue also exists in the "Moving Towards a Stable JavaScript API" document. (link to the section) |
|
The correct link for the moment is https://reactnative.dev/docs/next/strict-typescript-api We'll be having https://reactnative.dev/docs/strict-typescript-api on Monday as soon as we cut the docs for 0.80 (cc @hezi) |
|
I’ve checked the existence of the docs/next/strict-typescript-api document, but it doesn’t include information on opting out of the warning. If the opt-out instructions are included in the As for the "Moving Towards a Stable JavaScript API" post, it looks like the issue will be resolved on Monday 😄 |
|
closing - the link is working correctly. |
The opt-out link provided in the React Native 0.80 release blog post is currently not working.
(https://reactnative.dev/docs/strict-typescript-api)
I found a section in the “Moving Towards a Stable JavaScript API” blog post that explains how to opt out of the ESLint warning.
I’ve replaced the broken link with the link to that section.
In my opinion, this replacement isn’t ideal since the link doesn’t directly jump to the opt-out instructions.
However, it seems to be the best available alternative for now.