Fix producer::flush behavior and tests #777
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Make it easier to pass extra arguments to the test suite (`./test_suite.sh -- --nocapture` for example); * Implement fmt::Debug for Metadata; * Set up logging during producer tests. * Fix docs warnings.
| if ret.is_error() { | ||
| return Err(KafkaError::Flush(ret.into())); | ||
| loop { | ||
| match unsafe { rdsys::rd_kafka_flush(self.native_ptr(), 0) } { |
There was a problem hiding this comment.
It seems like the non blocking call should be on poll, not on rd_kafka_flush? This would allow the majority of the time to be spent on actually flushing the queues, and poll would just process everything that's ready?
Suggested change
| match unsafe { rdsys::rd_kafka_flush(self.native_ptr(), 0) } { | |
| match unsafe { rdsys::rd_kafka_flush(self.native_ptr(), deadline.remaining().min(Duration::from_millis(100))) } { |
There was this ticket regarding special casing rd_kafka_flush with a timeout of 0 though: confluentinc/librdkafka#1950 . The underlying implementation has changed significantly since that issue was resolved so I'm not sure if that's still valid.
There was a problem hiding this comment.
If this change is made, I think the logic around deciding when to poll might need adjusting too.
snakeice
reviewed
Jun 25, 2025
Co-authored-by: Rodrigo Bernardi <rodrigo@rbernardi.dev> Co-authored-by: David Blewett <david.blewett@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
./test_suite.sh -- --nocapturefor example);